Add unit tests for ui::WebView embedded fullscreen mode.

Add unit tests for ui::WebView embedded fullscreen mode.

Belated unit tests to confirm layout, attachment, etc. behaviors when
entering/leaving fullscreen-within-tab mode.

BUG=290403
Committed: https://crrev.com/b2b2eefceebbd6d5baa02a3c2d2e02a7c3e23ae1
Cr-Commit-Position: refs/heads/master@{#302001}

[miu, 2014-10-17 23:30:17]

miu@chromium.org changed reviewers:
+ ben@chromium.org

[miu, 2014-10-17 23:30:18]

ben: PTAL.  Better late than never!  ;-)

[tfarina, 2014-10-22 15:48:58]

https://codereview.chromium.org/662013003/diff/1/ui/views/controls/webview/we...
File ui/views/controls/webview/webview_unittest.cc (right):

https://codereview.chromium.org/662013003/diff/1/ui/views/controls/webview/we...
ui/views/controls/webview/webview_unittest.cc:169: // WebContentsDelegate
overrides.
s/WebContentsDelegate/content::WebContentsDelegate:

https://codereview.chromium.org/662013003/diff/1/ui/views/controls/webview/we...
ui/views/controls/webview/webview_unittest.cc:171: const content::WebContents*
ignored) const override {
looks like 'virtual' is not necessary anymore? May be it is to please clang
chromium-style plygin yet?

https://codereview.chromium.org/662013003/diff/1/ui/views/controls/webview/we...
ui/views/controls/webview/webview_unittest.cc:259: TEST_F(WebViewUnitTest,
EmbeddedFullscreenDuringScreenCapture_Layout) {
Copying Scott, in case he can review this.

[miu, 2014-10-22 20:07:18]

https://codereview.chromium.org/662013003/diff/1/ui/views/controls/webview/we...
File ui/views/controls/webview/webview_unittest.cc (right):

https://codereview.chromium.org/662013003/diff/1/ui/views/controls/webview/we...
ui/views/controls/webview/webview_unittest.cc:169: // WebContentsDelegate
overrides.
On 2014/10/22 15:48:58, tfarina wrote:
> s/WebContentsDelegate/content::WebContentsDelegate:

Done.

https://codereview.chromium.org/662013003/diff/1/ui/views/controls/webview/we...
ui/views/controls/webview/webview_unittest.cc:171: const content::WebContents*
ignored) const override {
On 2014/10/22 15:48:58, tfarina wrote:
> looks like 'virtual' is not necessary anymore? May be it is to please clang
> chromium-style plygin yet?

Done.  And changed to the new convention in the rest in this file.  Though, I
suspect someone's got an identical change in-progress at this very moment.  ;-)

[miu, 2014-10-28 21:06:55]

ben: Ping.

[miu, 2014-10-29 18:45:31]

miu@chromium.org changed reviewers:
+ sky@chromium.org

[miu, 2014-10-29 18:45:31]

sky: Ben's unresponsive.  Could you PTAL?

[sky, 2014-10-29 19:25:37]

https://codereview.chromium.org/662013003/diff/40001/ui/views/controls/webvie...
File ui/views/controls/webview/webview_unittest.cc (right):

https://codereview.chromium.org/662013003/diff/40001/ui/views/controls/webvie...
ui/views/controls/webview/webview_unittest.cc:263:
static_cast<views::NativeViewHost*>(web_view()->child_at(0));
Code like this is fragile, in so far as it's easy to break and have everything
continue compiling. I would rather you friend the test (or better yet the base
class here) and get the NativeViewHost through dedicated api.

[miu, 2014-10-29 21:23:24]

https://codereview.chromium.org/662013003/diff/40001/ui/views/controls/webvie...
File ui/views/controls/webview/webview_unittest.cc (right):

https://codereview.chromium.org/662013003/diff/40001/ui/views/controls/webvie...
ui/views/controls/webview/webview_unittest.cc:263:
static_cast<views::NativeViewHost*>(web_view()->child_at(0));
On 2014/10/29 19:25:37, sky wrote:
> Code like this is fragile, in so far as it's easy to break and have everything
> continue compiling. I would rather you friend the test (or better yet the base
> class here) and get the NativeViewHost through dedicated api.

Done.  I had to move the WebViewUnitTest class out of the anonymous namespace
and into the views namespace, to make the compiler happy with my friend class
declaration.

[sky, 2014-10-29 22:13:14]

LGTM

[miu, 2014-10-29 22:37:27]

The CQ bit was checked by miu@chromium.org

[commit-bot: I haz the power, 2014-10-29 22:41:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/662013003/60001

[commit-bot: I haz the power, 2014-10-30 00:59:48]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-10-30 01:00:21]

Patchset 4 (id:??) landed as
https://crrev.com/b2b2eefceebbd6d5baa02a3c2d2e02a7c3e23ae1
Cr-Commit-Position: refs/heads/master@{#302001}