Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 662003002: Add WebRuntimeFeatures::enableCSSViewport() feature (Closed)

Created:
6 years, 2 months ago by Mikhail
Modified:
6 years, 2 months ago
Reviewers:
Mike West
CC:
blink-reviews, dglazkov+blink, mkwst+moarreviews_chromium.org, Noel Gordon
Base URL:
https://chromium.googlesource.com/chromium/blink.git/+/master
Project:
blink
Visibility:
Public.

Description

Add WebRuntimeFeatures::enableCSSViewport() feature Add WebRuntimeFeatures::enableCSSViewport() method that should substitute the unfortunately named 'WebRuntimeFeatures::setCSSViewportEnabled()'. BUG=424459 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183899

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M Source/web/WebRuntimeFeatures.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Mikhail
PTAL
6 years, 2 months ago (2014-10-17 12:57:41 UTC) #2
Mike West
LGTM
6 years, 2 months ago (2014-10-17 13:10:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662003002/1
6 years, 2 months ago (2014-10-17 13:17:26 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/64816)
6 years, 2 months ago (2014-10-17 13:46:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662003002/1
6 years, 2 months ago (2014-10-17 13:48:11 UTC) #9
commit-bot: I haz the power
Failed to apply patch for public/web/WebRuntimeFeatures.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 2 months ago (2014-10-17 13:48:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662003002/20001
6 years, 2 months ago (2014-10-17 14:03:04 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 16:19:39 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 183899

Powered by Google App Engine
This is Rietveld 408576698