Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issue 661983002: Revert "android_webview: go back to using system ICU." (Closed)

Created:
6 years, 2 months ago by Torne
Modified:
6 years, 2 months ago
Reviewers:
benm (inactive)
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Revert "android_webview: go back to using system ICU." This reverts commit 96256bfea5c496aa70b1913555b1e1c7f166c426, returning the webview build to using Chrome's copy of ICU. BUG=409851 NOTRY=true Committed: https://crrev.com/2f017213ed940754da2bbc24fadd5386fe82e3fc Cr-Commit-Position: refs/heads/master@{#300092}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M android_webview/libwebviewchromium.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Torne
6 years, 2 months ago (2014-10-17 12:19:36 UTC) #2
benm (inactive)
lgtm
6 years, 2 months ago (2014-10-17 12:36:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661983002/1
6 years, 2 months ago (2014-10-17 12:41:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 12:42:35 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 12:43:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f017213ed940754da2bbc24fadd5386fe82e3fc
Cr-Commit-Position: refs/heads/master@{#300092}

Powered by Google App Engine
This is Rietveld 408576698