Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2153)

Unified Diff: content/renderer/devtools/devtools_agent.cc

Issue 66193005: Independently enable recording and event callback (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/browser_shutdown_profile_dumper.cc ('k') | webkit/child/webkitplatformsupport_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/devtools/devtools_agent.cc
diff --git a/content/renderer/devtools/devtools_agent.cc b/content/renderer/devtools/devtools_agent.cc
index a0693e519eb803f889e30d485ffea8d7d403f310..f504d65b69aa1004e9c28b45a5518a00715f3664 100644
--- a/content/renderer/devtools/devtools_agent.cc
+++ b/content/renderer/devtools/devtools_agent.cc
@@ -82,6 +82,7 @@ DevToolsAgent::DevToolsAgent(RenderViewImpl* render_view)
DevToolsAgent::~DevToolsAgent() {
g_agent_for_routing_id.Get().erase(routing_id());
+ setTraceEventCallback(NULL);
}
// Called on the Renderer thread.
@@ -137,15 +138,14 @@ void DevToolsAgent::clearBrowserCookies() {
void DevToolsAgent::setTraceEventCallback(TraceEventCallback cb) {
TraceLog* trace_log = TraceLog::GetInstance();
- trace_log->SetEventCallback(cb ? TraceEventCallbackWrapper : 0);
base::subtle::NoBarrier_Store(&event_callback_,
reinterpret_cast<base::subtle::AtomicWord>(cb));
if (!!cb) {
- trace_log->SetEnabled(base::debug::CategoryFilter(
+ trace_log->SetEventCallbackEnabled(base::debug::CategoryFilter(
base::debug::CategoryFilter::kDefaultCategoryFilterString),
- TraceLog::RECORD_UNTIL_FULL);
+ TraceEventCallbackWrapper);
} else {
- trace_log->SetDisabled();
+ trace_log->SetEventCallbackDisabled();
}
}
« no previous file with comments | « content/browser/browser_shutdown_profile_dumper.cc ('k') | webkit/child/webkitplatformsupport_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698