Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 661923005: DevTools: [Workspace] fix removing stylesheet-related uiSourceCodes (Closed)

Created:
6 years, 2 months ago by lushnikov
Modified:
6 years, 2 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git/+/master
Project:
blink
Visibility:
Public.

Description

DevTools: [Workspace] fix removing stylesheet-related uiSourceCodes The patch fixes a bug in removing uiSourceCodes from workspace as the associated stylesheet gets removed. BUG=424544 R=vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183915

Patch Set 1 #

Total comments: 2

Patch Set 2 : add one more testcase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -27 lines) Patch
M LayoutTests/inspector/sources/debugger/network-uisourcecode-provider.html View 1 2 chunks +42 lines, -25 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/network-uisourcecode-provider-expected.txt View 1 1 chunk +5 lines, -1 line 0 comments Download
M Source/devtools/front_end/bindings/NetworkWorkspaceBinding.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
lushnikov
PTAL
6 years, 2 months ago (2014-10-17 13:25:22 UTC) #1
vsevik
lgtm https://codereview.chromium.org/661923005/diff/1/LayoutTests/inspector/sources/debugger/network-uisourcecode-provider.html File LayoutTests/inspector/sources/debugger/network-uisourcecode-provider.html (right): https://codereview.chromium.org/661923005/diff/1/LayoutTests/inspector/sources/debugger/network-uisourcecode-provider.html#newcode14 LayoutTests/inspector/sources/debugger/network-uisourcecode-provider.html:14: sourceURL: "http://example.com/foo.css", Please test for both sourceURLs
6 years, 2 months ago (2014-10-17 13:42:55 UTC) #2
lushnikov
https://codereview.chromium.org/661923005/diff/1/LayoutTests/inspector/sources/debugger/network-uisourcecode-provider.html File LayoutTests/inspector/sources/debugger/network-uisourcecode-provider.html (right): https://codereview.chromium.org/661923005/diff/1/LayoutTests/inspector/sources/debugger/network-uisourcecode-provider.html#newcode14 LayoutTests/inspector/sources/debugger/network-uisourcecode-provider.html:14: sourceURL: "http://example.com/foo.css", On 2014/10/17 13:42:55, vsevik wrote: > Please ...
6 years, 2 months ago (2014-10-17 17:29:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661923005/20001
6 years, 2 months ago (2014-10-17 17:31:52 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 19:04:40 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 183915

Powered by Google App Engine
This is Rietveld 408576698