Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: pkg/analyzer2dart/lib/src/cps_generator.dart

Issue 661923003: Support binary expressions in analyzer2dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer2dart/lib/src/cps_generator.dart
diff --git a/pkg/analyzer2dart/lib/src/cps_generator.dart b/pkg/analyzer2dart/lib/src/cps_generator.dart
index c2e1b90a141ed1a3108771ebb85dbf484f63f09e..94c890d4c90b75c6808733d6c98e9a14c8348a10 100644
--- a/pkg/analyzer2dart/lib/src/cps_generator.dart
+++ b/pkg/analyzer2dart/lib/src/cps_generator.dart
@@ -187,4 +187,38 @@ class CpsGeneratingVisitor extends SemanticVisitor<ir.Node>
return irBuilder.buildStaticGet(target,
new Selector.getter(target.name, target.library));
}
+
+ ir.Primitive handleBinaryExpression(BinaryExpression node,
+ String op) {
+ ir.Primitive left = node.leftOperand.accept(this);
+ ir.Primitive right = node.rightOperand.accept(this);
+ Selector selector = new Selector.binaryOperator(op);
+ return irBuilder.buildDynamicInvocation(
+ left, selector, <ir.Definition>[right]);
+ }
+
+ ir.Node handleLazyOperator(BinaryExpression node, {bool isLazyOr: false}) {
+ ir.Primitive left = node.leftOperand.accept(this);
+ ir.Primitive buildRightValue(IrBuilder builder) {
+ return withBuilder(builder, () => node.rightOperand.accept(this));
+ }
+ return irBuilder.buildLogicalOperator(
+ left, buildRightValue, isLazyOr: isLazyOr);
+ }
+
+ @override
+ ir.Node visitBinaryExpression(BinaryExpression node) {
+ // TODO(johnniwinther,paulberry,brianwilkerson): The operator should be
+ // available through an enum.
+ String op = node.operator.lexeme;
+ switch (op) {
+ case '||':
+ case '&&':
+ return handleLazyOperator(node, isLazyOr: op == '||');
+ case '!=':
+ return irBuilder.buildNegation(handleBinaryExpression(node, '=='));
+ default:
+ return handleBinaryExpression(node, op);
+ }
+ }
}

Powered by Google App Engine
This is Rietveld 408576698