Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2036)

Issue 661923002: Implement graph trimming in ControlReducer. (Closed)

Created:
6 years, 2 months ago by titzer
Modified:
6 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Implement graph trimming in ControlReducer. Trimming the graph consists of breaking links from nodes that are not reachable from end to nodes that are reachable from end. Such dead nodes show up in the use lists of the live nodes and though mostly harmless, just clutter up the graph. They also can limit instruction selection opportunities, so it is good to get rid of them. This CL is one half of the ControlReducer functionality, the other half being branch folding. R=bmeurer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24694

Patch Set 1 #

Patch Set 2 : Test status for mjsunit/asm/infinite-loops.asm. #

Total comments: 4

Patch Set 3 : Use Deque. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+871 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A src/compiler/control-reducer.h View 1 chunk +27 lines, -0 lines 0 comments Download
A src/compiler/control-reducer.cc View 1 2 1 chunk +122 lines, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/cctest.status View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A test/cctest/compiler/test-control-reducer.cc View 1 chunk +242 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-jsbranches.cc View 1 2 1 chunk +75 lines, -0 lines 0 comments Download
A test/mjsunit/asm/do-while-false.js View 1 chunk +78 lines, -0 lines 0 comments Download
A test/mjsunit/asm/if-folding.js View 1 chunk +100 lines, -0 lines 0 comments Download
A test/mjsunit/asm/if-reduction.js View 1 chunk +111 lines, -0 lines 0 comments Download
A test/mjsunit/asm/infinite-loops.js View 1 chunk +53 lines, -0 lines 0 comments Download
A test/mjsunit/asm/infinite-loops-taken.js View 1 chunk +41 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
titzer
6 years, 2 months ago (2014-10-17 08:21:48 UTC) #1
Benedikt Meurer
https://codereview.chromium.org/661923002/diff/20001/src/compiler/control-reducer.cc File src/compiler/control-reducer.cc (right): https://codereview.chromium.org/661923002/diff/20001/src/compiler/control-reducer.cc#newcode37 src/compiler/control-reducer.cc:37: NodeVector stack_; Nit: Use deque here, or even better ...
6 years, 2 months ago (2014-10-17 09:46:44 UTC) #2
Benedikt Meurer
LGTM if nits are addressed.
6 years, 2 months ago (2014-10-17 09:46:56 UTC) #3
titzer
https://codereview.chromium.org/661923002/diff/20001/src/compiler/control-reducer.cc File src/compiler/control-reducer.cc (right): https://codereview.chromium.org/661923002/diff/20001/src/compiler/control-reducer.cc#newcode37 src/compiler/control-reducer.cc:37: NodeVector stack_; On 2014/10/17 09:46:44, Benedikt Meurer wrote: > ...
6 years, 2 months ago (2014-10-17 11:15:51 UTC) #4
titzer
6 years, 2 months ago (2014-10-17 11:52:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as 24694 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698