chrome/browser/ui/app_list/app_list_syncable_service.cc - Issue 661913002: Fix ModelPrefUpdater destruction order.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/app_list_syncable_service.cc

Issue 661913002: Fix ModelPrefUpdater destruction order. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@app_list_pref

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/app_list/app_list_syncable_service.cc

diff --git a/chrome/browser/ui/app_list/app_list_syncable_service.cc b/chrome/browser/ui/app_list/app_list_syncable_service.cc

index 8f966897e30f12fb005960dbc42b11c2e239dfb3..9745f11a0e311225eebeb80615a7e066055a70d1 100644

--- a/chrome/browser/ui/app_list/app_list_syncable_service.cc

+++ b/chrome/browser/ui/app_list/app_list_syncable_service.cc

@@ -246,6 +246,7 @@ AppListSyncableService::AppListSyncableService(

AppListSyncableService::~AppListSyncableService() {

// Remove observers.

model_observer_.reset();

+ model_pref_updater_.reset();

STLDeleteContainerPairSecondPointers(sync_items_.begin(), sync_items_.end());

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »