Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 661913002: Fix ModelPrefUpdater destruction order. (Closed)

Created:
6 years, 2 months ago by calamity
Modified:
6 years, 2 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@app_list_pref
Project:
chromium
Visibility:
Public.

Description

Fix ModelPrefUpdater destruction order. This CL fixes an issue where AppListSyncableService would free the model before the ModelPrefUpdater that was observing it. BUG=423124 Committed: https://crrev.com/01686d7054d85bcf5d43fa5693f4c89727173fed Cr-Commit-Position: refs/heads/master@{#300072}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/app_list/app_list_syncable_service.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
calamity
Thanks for diagnosing.
6 years, 2 months ago (2014-10-17 04:38:30 UTC) #2
xiyuan
LGTM Thank you for the quick fix.
6 years, 2 months ago (2014-10-17 04:58:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661913002/1
6 years, 2 months ago (2014-10-17 05:26:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 06:30:03 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 06:30:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01686d7054d85bcf5d43fa5693f4c89727173fed
Cr-Commit-Position: refs/heads/master@{#300072}

Powered by Google App Engine
This is Rietveld 408576698