Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 661843003: Fixed extraction of emulated devices name (Closed)

Created:
6 years, 2 months ago by ripp
Modified:
6 years, 2 months ago
Reviewers:
klundberg, jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, craigdh, frankf
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixed extraction of emulated devices name The adb_logcat_* scripts are extract attached devices names with pattern 'w+', but it only works for real devices. Emulated devices have names in form of 'emulator-5554' and '-' sign is not matched by 'w+' parrent. This causes to logcat output to be missed while tests are running R=frankf@chromium.org, craigdh@chromium.org TEST=Run tests with only emulators attached, ensure that resulting log contains logcal output Committed: https://crrev.com/044549b9d574c6fb633287a8ddb5f2df12be2b24 Cr-Commit-Position: refs/heads/master@{#300242}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/android/adb_logcat_monitor.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/adb_logcat_printer.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
ripp
6 years, 2 months ago (2014-10-17 11:13:41 UTC) #1
klundberg
- craigdh, frankf as they have left Chrome + jbudorick
6 years, 2 months ago (2014-10-17 14:28:56 UTC) #3
jbudorick
lgtm Thanks for the patch!
6 years, 2 months ago (2014-10-17 17:36:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661843003/1
6 years, 2 months ago (2014-10-20 06:00:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-20 09:38:31 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 09:39:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/044549b9d574c6fb633287a8ddb5f2df12be2b24
Cr-Commit-Position: refs/heads/master@{#300242}

Powered by Google App Engine
This is Rietveld 408576698