Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: media/audio/virtual_audio_output_stream_unittest.cc

Issue 66183002: Replace MessageLoopProxy with SingleThreadTaskRunner for the rest of media/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix win and audio tests Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/audio/virtual_audio_input_stream_unittest.cc ('k') | media/audio/win/audio_manager_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/virtual_audio_output_stream_unittest.cc
diff --git a/media/audio/virtual_audio_output_stream_unittest.cc b/media/audio/virtual_audio_output_stream_unittest.cc
index 1e3abd1c6bb3c7edbe1225c7c60c9536bf88cd97..72e794d6febdb4492c3c5b20ea0b0b358905212e 100644
--- a/media/audio/virtual_audio_output_stream_unittest.cc
+++ b/media/audio/virtual_audio_output_stream_unittest.cc
@@ -4,8 +4,6 @@
#include "base/bind.h"
#include "base/bind_helpers.h"
-#include "base/message_loop/message_loop.h"
-#include "base/message_loop/message_loop_proxy.h"
#include "base/synchronization/waitable_event.h"
#include "base/threading/thread.h"
#include "media/audio/audio_manager.h"
@@ -27,10 +25,10 @@ const AudioParameters kParams(
class MockVirtualAudioInputStream : public VirtualAudioInputStream {
public:
explicit MockVirtualAudioInputStream(
- const scoped_refptr<base::MessageLoopProxy>& worker_loop)
+ const scoped_refptr<base::SingleThreadTaskRunner>& worker_task_runner)
: VirtualAudioInputStream(
kParams,
- worker_loop,
+ worker_task_runner,
base::Bind(&base::DeletePointer<VirtualAudioInputStream>)) {}
~MockVirtualAudioInputStream() {}
@@ -53,16 +51,16 @@ class VirtualAudioOutputStreamTest : public testing::Test {
VirtualAudioOutputStreamTest()
: audio_thread_(new base::Thread("AudioThread")) {
audio_thread_->Start();
- audio_message_loop_ = audio_thread_->message_loop_proxy();
+ audio_task_runner_ = audio_thread_->message_loop_proxy();
}
- const scoped_refptr<base::MessageLoopProxy>& audio_message_loop() const {
- return audio_message_loop_;
+ const scoped_refptr<base::SingleThreadTaskRunner>& audio_task_runner() const {
+ return audio_task_runner_;
}
void SyncWithAudioThread() {
base::WaitableEvent done(false, false);
- audio_message_loop()->PostTask(
+ audio_task_runner()->PostTask(
FROM_HERE, base::Bind(&base::WaitableEvent::Signal,
base::Unretained(&done)));
done.Wait();
@@ -70,7 +68,7 @@ class VirtualAudioOutputStreamTest : public testing::Test {
private:
scoped_ptr<base::Thread> audio_thread_;
- scoped_refptr<base::MessageLoopProxy> audio_message_loop_;
+ scoped_refptr<base::SingleThreadTaskRunner> audio_task_runner_;
DISALLOW_COPY_AND_ASSIGN(VirtualAudioOutputStreamTest);
};
@@ -79,8 +77,8 @@ TEST_F(VirtualAudioOutputStreamTest, StartStopStartStop) {
static const int kCycles = 3;
MockVirtualAudioInputStream* const input_stream =
- new MockVirtualAudioInputStream(audio_message_loop());
- audio_message_loop()->PostTask(
+ new MockVirtualAudioInputStream(audio_task_runner());
+ audio_task_runner()->PostTask(
FROM_HERE, base::Bind(
base::IgnoreResult(&MockVirtualAudioInputStream::Open),
base::Unretained(input_stream)));
@@ -95,24 +93,24 @@ TEST_F(VirtualAudioOutputStreamTest, StartStopStartStop) {
EXPECT_CALL(*input_stream, RemoveOutputStream(output_stream, _))
.Times(kCycles);
- audio_message_loop()->PostTask(
+ audio_task_runner()->PostTask(
FROM_HERE, base::Bind(base::IgnoreResult(&VirtualAudioOutputStream::Open),
base::Unretained(output_stream)));
SineWaveAudioSource source(CHANNEL_LAYOUT_STEREO, 200.0, 128);
for (int i = 0; i < kCycles; ++i) {
- audio_message_loop()->PostTask(
+ audio_task_runner()->PostTask(
FROM_HERE, base::Bind(&VirtualAudioOutputStream::Start,
base::Unretained(output_stream),
&source));
- audio_message_loop()->PostTask(
+ audio_task_runner()->PostTask(
FROM_HERE, base::Bind(&VirtualAudioOutputStream::Stop,
base::Unretained(output_stream)));
}
- audio_message_loop()->PostTask(
+ audio_task_runner()->PostTask(
FROM_HERE, base::Bind(&VirtualAudioOutputStream::Close,
base::Unretained(output_stream)));
- audio_message_loop()->PostTask(
+ audio_task_runner()->PostTask(
FROM_HERE, base::Bind(&MockVirtualAudioInputStream::Close,
base::Unretained(input_stream)));
« no previous file with comments | « media/audio/virtual_audio_input_stream_unittest.cc ('k') | media/audio/win/audio_manager_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698