Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 66183002: Replace MessageLoopProxy with SingleThreadTaskRunner for the rest of media/. (Closed)

Created:
7 years, 1 month ago by scherkus (not reviewing)
Modified:
6 years, 11 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, extensions-reviews_chromium.org, fischman+watch_chromium.org, jam, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Replace MessageLoopProxy with SingleThreadTaskRunner for the rest of media/. BUG=315922 R=dalecurtis@chromium.org TBR=jam Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243390

Patch Set 1 : #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : fix win and audio tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+418 lines, -464 lines) Patch
M chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc View 1 9 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_renderer_host.cc View 1 1 chunk +6 lines, -5 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/web_contents_audio_input_stream.h View 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/renderer_host/media/web_contents_audio_input_stream.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/webrtc_audio_device_test.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/webrtc_audio_device_test.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download
M media/audio/alsa/alsa_output.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M media/audio/alsa/alsa_output_unittest.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M media/audio/android/audio_manager_android.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_input_controller.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M media/audio/audio_input_controller.cc View 1 14 chunks +24 lines, -24 lines 0 comments Download
M media/audio/audio_input_device.h View 2 chunks +5 lines, -4 lines 0 comments Download
M media/audio/audio_input_device.cc View 11 chunks +13 lines, -14 lines 0 comments Download
M media/audio/audio_low_latency_input_output_unittest.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M media/audio/audio_manager.h View 1 3 chunks +9 lines, -10 lines 0 comments Download
M media/audio/audio_manager_base.h View 1 2 3 chunks +7 lines, -6 lines 0 comments Download
M media/audio/audio_manager_base.cc View 1 10 chunks +16 lines, -16 lines 0 comments Download
M media/audio/audio_output_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_output_controller.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M media/audio/audio_output_controller_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_output_device.h View 2 chunks +5 lines, -5 lines 0 comments Download
M media/audio/audio_output_device.cc View 12 chunks +15 lines, -16 lines 0 comments Download
M media/audio/audio_output_dispatcher.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M media/audio/audio_output_dispatcher.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M media/audio/audio_output_dispatcher_impl.cc View 1 10 chunks +12 lines, -12 lines 0 comments Download
M media/audio/audio_output_proxy_unittest.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M media/audio/audio_output_resampler.cc View 1 8 chunks +9 lines, -9 lines 0 comments Download
M media/audio/clockless_audio_sink.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/fake_audio_consumer.h View 2 chunks +7 lines, -6 lines 0 comments Download
M media/audio/fake_audio_consumer.cc View 8 chunks +15 lines, -14 lines 0 comments Download
M media/audio/fake_audio_output_stream.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M media/audio/mac/audio_manager_mac.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M media/audio/mac/audio_manager_mac.cc View 1 3 chunks +7 lines, -7 lines 0 comments Download
M media/audio/mock_audio_manager.h View 1 3 chunks +6 lines, -4 lines 0 comments Download
M media/audio/mock_audio_manager.cc View 1 2 chunks +9 lines, -8 lines 0 comments Download
M media/audio/null_audio_sink.h View 3 chunks +3 lines, -3 lines 0 comments Download
M media/audio/null_audio_sink.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M media/audio/pulse/pulse_output.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M media/audio/pulse/pulse_unified.cc View 7 chunks +8 lines, -8 lines 0 comments Download
D media/audio/scoped_loop_observer.h View 1 chunk +0 lines, -50 lines 0 comments Download
D media/audio/scoped_loop_observer.cc View 1 chunk +0 lines, -47 lines 0 comments Download
A media/audio/scoped_task_runner_observer.h View 1 chunk +52 lines, -0 lines 0 comments Download
A + media/audio/scoped_task_runner_observer.cc View 2 chunks +11 lines, -10 lines 0 comments Download
M media/audio/sounds/audio_stream_handler.cc View 1 7 chunks +9 lines, -9 lines 0 comments Download
M media/audio/sounds/sounds_manager.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M media/audio/test_audio_input_controller_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/audio/virtual_audio_input_stream.h View 3 chunks +6 lines, -6 lines 0 comments Download
M media/audio/virtual_audio_input_stream.cc View 1 3 chunks +6 lines, -7 lines 0 comments Download
M media/audio/virtual_audio_input_stream_unittest.cc View 1 5 chunks +12 lines, -13 lines 0 comments Download
M media/audio/virtual_audio_output_stream_unittest.cc View 6 chunks +14 lines, -16 lines 0 comments Download
M media/audio/win/audio_manager_win.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M media/base/bind_to_loop_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/media.gyp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M media/tools/player_x11/player_x11.cc View 1 2 chunks +12 lines, -11 lines 0 comments Download
M media/video/capture/mac/video_capture_device_mac.h View 1 2 chunks +5 lines, -2 lines 0 comments Download
M media/video/capture/mac/video_capture_device_mac.mm View 1 6 chunks +8 lines, -7 lines 0 comments Download
M media/video/capture/video_capture_device_unittest.cc View 1 2 chunks +1 line, -3 lines 0 comments Download
M media/video/capture/video_capture_proxy.h View 3 chunks +3 lines, -3 lines 0 comments Download
M media/video/capture/video_capture_proxy.cc View 1 7 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scherkus (not reviewing)
you get this one because changing AudioManager::GetMessageLoop() required changing the world I did a scan ...
7 years, 1 month ago (2013-11-08 03:40:07 UTC) #1
DaleCurtis
lgtm, though my eyes crossed somewhere around line 9001. https://codereview.chromium.org/66183002/diff/30001/media/audio/scoped_task_runner_observer.h File media/audio/scoped_task_runner_observer.h (right): https://codereview.chromium.org/66183002/diff/30001/media/audio/scoped_task_runner_observer.h#newcode24 media/audio/scoped_task_runner_observer.h:24: ...
7 years, 1 month ago (2013-11-08 19:32:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/66183002/800001
6 years, 11 months ago (2014-01-07 18:34:48 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242612
6 years, 11 months ago (2014-01-07 21:05:52 UTC) #4
scherkus (not reviewing)
6 years, 11 months ago (2014-01-07 21:42:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r243390 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698