Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 661823002: Revert of Ensure that the browser’s copy of page id is in sync with the renderer’s. (Closed)

Created:
6 years, 2 months ago by Avi (use Gerrit)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Ensure that the browser’s copy of page id is in sync with the renderer’s. (patchset #1 id:1 of https://codereview.chromium.org/657233002/) Reason for revert: It's crashing... drat. Original issue's description: > Ensure that the browser’s copy of page id is in sync with the renderer’s. > > This might-maybe-hope-not crash, and so has debugging statements. > > BUG=407376 > TEST=no crashing, we hope > > Committed: https://crrev.com/b49b70f26e6d0f2f54bb87cf374f30a339c7d7c6 > Cr-Commit-Position: refs/heads/master@{#299822} TBR=rsesek@chromium.org,creis@chromium.org NOTREECHECKS=true NOTRY=true BUG=407376 Committed: https://crrev.com/56d8d758406d002bb95d4c11f9e844ac0c9837a0 Cr-Commit-Position: refs/heads/master@{#299945}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -35 lines) Patch
M chrome/common/crash_keys.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +0 lines, -25 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
Created Revert of Ensure that the browser’s copy of page id is in sync with ...
6 years, 2 months ago (2014-10-16 18:56:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661823002/1
6 years, 2 months ago (2014-10-16 18:58:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 18:59:27 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 19:00:12 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56d8d758406d002bb95d4c11f9e844ac0c9837a0
Cr-Commit-Position: refs/heads/master@{#299945}

Powered by Google App Engine
This is Rietveld 408576698