Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 661803004: Enabled the new PageInfo dialog on Android by default (Closed)

Created:
6 years, 2 months ago by sashab
Modified:
6 years, 2 months ago
Reviewers:
Ted C
CC:
chromium-reviews, benwells
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enabled the new PageInfo dialog on Android by default Changed the flag '--enable-new-website-settings' to '--disable-new-website-settings', which enables the new PageInfo dialog on Android by default. The dialog can be launched by selecting the lock icon on non-HTTP pages, or long-pressing on the URL bar on HTTP pages. BUG=302553 Committed: https://crrev.com/9cee6105930e94ad2abf2c004efb1d65c0759a0f Cr-Commit-Position: refs/heads/master@{#300789}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/ChromeSwitches.java View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sashab
6 years, 2 months ago (2014-10-22 09:38:15 UTC) #2
Ted C
lgtm -- I added a downstream check for this flag as well for the long ...
6 years, 2 months ago (2014-10-22 17:15:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661803004/1
6 years, 2 months ago (2014-10-22 21:47:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-22 23:04:11 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 23:05:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9cee6105930e94ad2abf2c004efb1d65c0759a0f
Cr-Commit-Position: refs/heads/master@{#300789}

Powered by Google App Engine
This is Rietveld 408576698