Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 661803003: Revert of Refactor source_control.py and add a test. (Closed)

Created:
6 years, 2 months ago by prasadv
Modified:
6 years, 1 month ago
Reviewers:
qyearsley, ojan
CC:
chromium-reviews, RobertoCN, Sergiy Byelozyorov
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Refactor source_control.py and add a test. (patchset #3 id:40001 of https://codereview.chromium.org/650223005/) Reason for revert: This broke syncing source for dependency repos while bisecting them, http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus7_perf_bisect/builds/384/steps/Working%20on%20%5Bc519ca88f8ed073ff523f03eee8cb05d8b848fc5%5D/logs/stdio Original issue's description: > Refactor source_control.py and add a test. > > Originally, Simon made SourceControl a class becaused we expected to > add a SvnSourceControl subclass which implemented the same methods in > different ways. However, after the git transition we're fairly sure > that we don't want to do this. > > So, all of the functions in the SourceControl class can be made top-level > functions that don't need a "self" argument. This way, there's no need > to pass around a bogus SourceControl object; the functions can be called > directly. > > I also added tests for some methods that seemed relatively testable. > > PTAL and give suggestions :-) > > BUG= > > Committed: https://crrev.com/880741668d3ed0e08ea2229bb8965998abe775a3 > Cr-Commit-Position: refs/heads/master@{#299851} TBR=ojan@chromium.org,qyearsley@chromium.org NOTREECHECKS=true NOTRY=true BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+348 lines, -384 lines) Patch
M tools/auto_bisect/bisect_perf_regression.py View 25 chunks +51 lines, -43 lines 0 comments Download
M tools/auto_bisect/bisect_perf_regression_test.py View 4 chunks +17 lines, -8 lines 0 comments Download
M tools/auto_bisect/bisect_results.py View 4 chunks +4 lines, -4 lines 0 comments Download
M tools/auto_bisect/source_control.py View 2 chunks +276 lines, -245 lines 0 comments Download
D tools/auto_bisect/source_control_test.py View 1 chunk +0 lines, -84 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
prasadv
Created Revert of Refactor source_control.py and add a test.
6 years, 2 months ago (2014-10-20 17:11:33 UTC) #1
qyearsley
6 years, 2 months ago (2014-10-20 17:54:18 UTC) #2
On 2014/10/20 17:11:33, prasadv wrote:
> Created Revert of Refactor source_control.py and add a test.

Note: This revert may not be necessary (and therefore could be closed) if the
patch CL https://codereview.chromium.org/662403003/ works.

Powered by Google App Engine
This is Rietveld 408576698