Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 661763003: Ensure canvas state is preserved when 2d canvas falls out of display list mode (Closed)

Created:
6 years, 2 months ago by Justin Novosad
Modified:
6 years, 2 months ago
Reviewers:
Stephen White
CC:
blink-reviews, krit, Rik, jbroman, mkwst+moarreviews_chromium.org, danakj, pdr+graphicswatchlist_chromium.org, Stephen Chennney, rwlbuis
Project:
blink
Visibility:
Public.

Description

Ensure canvas state is preserved when 2d canvas falls out of display list mode This change adds code to save and replay the canvas state stack when transferring from a display list to a raste canvas BUG=423913 TEST=fast/canvas/canvas-unballanced-save.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183904

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -0 lines) Patch
A LayoutTests/fast/canvas/canvas-unbalanced-save.html View 1 1 chunk +31 lines, -0 lines 0 comments Download
A LayoutTests/fast/canvas/canvas-unbalanced-save-expected.html View 1 1 chunk +14 lines, -0 lines 0 comments Download
M Source/platform/graphics/RecordingImageBufferSurface.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Justin Novosad
PTAL
6 years, 2 months ago (2014-10-16 17:16:16 UTC) #2
Stephen White
Nit: unballanced -> unbalanced
6 years, 2 months ago (2014-10-16 17:39:09 UTC) #3
Stephen White
LGTM w/nits https://codereview.chromium.org/661763003/diff/1/LayoutTests/fast/canvas/canvas-unballanced-save.html File LayoutTests/fast/canvas/canvas-unballanced-save.html (right): https://codereview.chromium.org/661763003/diff/1/LayoutTests/fast/canvas/canvas-unballanced-save.html#newcode27 LayoutTests/fast/canvas/canvas-unballanced-save.html:27: } Nit: weird indentation here.
6 years, 2 months ago (2014-10-16 17:40:47 UTC) #4
Justin Novosad
https://codereview.chromium.org/661763003/diff/1/LayoutTests/fast/canvas/canvas-unballanced-save.html File LayoutTests/fast/canvas/canvas-unballanced-save.html (right): https://codereview.chromium.org/661763003/diff/1/LayoutTests/fast/canvas/canvas-unballanced-save.html#newcode27 LayoutTests/fast/canvas/canvas-unballanced-save.html:27: } On 2014/10/16 17:40:47, Stephen White wrote: > Nit: ...
6 years, 2 months ago (2014-10-16 18:05:02 UTC) #5
Justin Novosad
new patch
6 years, 2 months ago (2014-10-16 18:08:09 UTC) #6
Stephen White
LGTM
6 years, 2 months ago (2014-10-16 18:57:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661763003/20001
6 years, 2 months ago (2014-10-16 18:59:33 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/64329)
6 years, 2 months ago (2014-10-16 19:06:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661763003/20001
6 years, 2 months ago (2014-10-17 16:09:32 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 17:21:00 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 183904

Powered by Google App Engine
This is Rietveld 408576698