Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 661753002: DevTools: draw realistic chrome on top of viewport in layers3dview (Closed)

Created:
6 years, 2 months ago by caseq
Modified:
6 years, 2 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: draw realistic chrome on top of viewport in layers3dview - add graphics for chrome on top of viewport rectange; - make viewport border light-grey, let its width scale along with contents scale. - change Viewport checkbox to Chrome (always show viewport) - (drive by) properly handle potential image/texture creation errors - (drive by) disable user selection on Layers3DView in CSS as annoying. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183906

Patch Set 1 #

Patch Set 2 : fixed sandwich menu color #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -33 lines) Patch
M Source/devtools/devtools.gypi View 1 1 chunk +3 lines, -0 lines 0 comments Download
A Source/devtools/front_end/Images/chromeLeft.png View 1 Binary file 0 comments Download
A Source/devtools/front_end/Images/chromeMiddle.png View Binary file 0 comments Download
A Source/devtools/front_end/Images/chromeRight.png View 1 Binary file 0 comments Download
M Source/devtools/front_end/timeline/Layers3DView.js View 17 chunks +99 lines, -33 lines 0 comments Download
M Source/devtools/front_end/timelinePanel.css View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
caseq
6 years, 2 months ago (2014-10-16 12:57:15 UTC) #2
caseq
Screenshot: https://drive.google.com/a/chromium.org/file/d/0B_yi9xtujhXSb3g4c2xkY0ZyR3c/view?usp=sharing
6 years, 2 months ago (2014-10-16 13:02:35 UTC) #3
pfeldman
lgtm
6 years, 2 months ago (2014-10-17 14:57:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661753002/20001
6 years, 2 months ago (2014-10-17 15:51:53 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 17:21:39 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 183906

Powered by Google App Engine
This is Rietveld 408576698