Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 661743005: Moved constants out of web_view.js and into a new file, web_view_constants.js, so that the constant… (Closed)

Created:
6 years, 2 months ago by paulmeyer
Modified:
6 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Moved constants out of web_view.js and into a new file, web_view_constants.js, so that the constants can be shared by multiple webview files. Committed: https://crrev.com/ccbfe27c8d2b4fcb7ddc98064ec6aa5820fcfe9a Cr-Commit-Position: refs/heads/master@{#300547}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -49 lines) Patch
M extensions/renderer/dispatcher.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M extensions/renderer/resources/extensions_renderer_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/renderer/resources/guest_view/web_view.js View 14 chunks +36 lines, -49 lines 0 comments Download
A extensions/renderer/resources/guest_view/web_view_constants.js View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
paulmeyer
+fsamuel@ for guest_view/ +rockot@ for dispatcher.cc and extensions_renderer_resources.grd
6 years, 2 months ago (2014-10-21 17:49:40 UTC) #2
Fady Samuel
Horray for cleanup! LGTM
6 years, 2 months ago (2014-10-21 17:56:31 UTC) #3
Ken Rockot(use gerrit already)
lgtm
6 years, 2 months ago (2014-10-21 19:09:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661743005/1
6 years, 2 months ago (2014-10-21 19:11:49 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_triggered_tests/builds/61048)
6 years, 2 months ago (2014-10-21 20:07:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661743005/1
6 years, 2 months ago (2014-10-21 20:17:41 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 20:26:49 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 20:28:01 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ccbfe27c8d2b4fcb7ddc98064ec6aa5820fcfe9a
Cr-Commit-Position: refs/heads/master@{#300547}

Powered by Google App Engine
This is Rietveld 408576698