Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 661743004: Implement Fingerprint256 for SHA-256 fingerprints of certificates (Closed)

Created:
6 years, 2 months ago by Eran Messeri
Modified:
6 years, 2 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org, vadimgo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Implement Fingerprint256 for SHA-256 fingerprints of certificates BUG= Committed: https://crrev.com/388263b3dd3c48a845a35da16ab9caa659726c25 Cr-Commit-Position: refs/heads/master@{#300527}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -0 lines) Patch
M net/cert/x509_certificate.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/cert/x509_certificate_ios.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M net/cert/x509_certificate_mac.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M net/cert/x509_certificate_nss.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M net/cert/x509_certificate_openssl.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M net/cert/x509_certificate_unittest.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M net/cert/x509_certificate_win.cc View 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Eran Messeri
This has been reviewed in https://codereview.chromium.org/547603002.
6 years, 2 months ago (2014-10-21 15:14:47 UTC) #2
Ryan Sleevi
lgtm
6 years, 2 months ago (2014-10-21 17:45:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661743004/1
6 years, 2 months ago (2014-10-21 17:47:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 18:39:46 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 18:40:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/388263b3dd3c48a845a35da16ab9caa659726c25
Cr-Commit-Position: refs/heads/master@{#300527}

Powered by Google App Engine
This is Rietveld 408576698