Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1801)

Issue 661743003: Implement padding PUSH_PROMISE and HEADERS frames. (Closed)

Created:
6 years, 2 months ago by Bence
Modified:
6 years, 2 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Implement padding PUSH_PROMISE and HEADERS frames. This lands server change 77795511 by raullenchai. BUG=345769 Committed: https://crrev.com/498174e93a3e6c1909d4aa81891587d867820e23 Cr-Commit-Position: refs/heads/master@{#300713}

Patch Set 1 #

Patch Set 2 : Merge forgotten change in test. #

Patch Set 3 : Rebase. #

Patch Set 4 : Avoid MSVS warning C4800. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+383 lines, -91 lines) Patch
M net/spdy/spdy_framer.h View 4 chunks +6 lines, -3 lines 0 comments Download
M net/spdy/spdy_framer.cc View 1 2 3 17 chunks +94 lines, -40 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 1 2 7 chunks +247 lines, -44 lines 0 comments Download
M net/spdy/spdy_protocol.h View 1 2 3 chunks +36 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
Bence
Ryan, PTAL. Thank you.
6 years, 2 months ago (2014-10-21 15:49:19 UTC) #2
Ryan Hamilton
lgtm
6 years, 2 months ago (2014-10-21 19:48:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661743003/20001
6 years, 2 months ago (2014-10-21 19:51:57 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_swarming/builds/21238)
6 years, 2 months ago (2014-10-21 20:37:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661743003/20001
6 years, 2 months ago (2014-10-22 12:47:28 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg/builds/27049)
6 years, 2 months ago (2014-10-22 13:27:37 UTC) #11
Bence
Such code: bool has_bit = flags & BITMASK results in warning C4800: 'int' : forcing ...
6 years, 2 months ago (2014-10-22 14:19:38 UTC) #13
Bence
Ryan: PTAL.
6 years, 2 months ago (2014-10-22 15:06:08 UTC) #15
Ryan Hamilton
lgtm
6 years, 2 months ago (2014-10-22 15:47:05 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661743003/100001
6 years, 2 months ago (2014-10-22 16:02:31 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:100001)
6 years, 2 months ago (2014-10-22 18:29:27 UTC) #19
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 18:30:37 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/498174e93a3e6c1909d4aa81891587d867820e23
Cr-Commit-Position: refs/heads/master@{#300713}

Powered by Google App Engine
This is Rietveld 408576698