Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 661743002: Content Shell: Move shell_layout_tests_android into layout_tests/. (Closed)

Created:
6 years, 2 months ago by Mike West
Modified:
6 years, 2 months ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Content Shell: Move shell_layout_tests_android into layout_tests/. BUG=420994 Committed: https://crrev.com/d6805d0d1d21976cf16d0237d9091f7eebea4ea5 Cr-Commit-Position: refs/heads/master@{#299892}

Patch Set 1 #

Patch Set 2 : Fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -129 lines) Patch
M content/content_shell.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
A + content/shell/browser/layout_test/layout_test_android.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + content/shell/browser/layout_test/layout_test_android.cc View 1 2 chunks +1 line, -3 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_browser_main.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/shell/browser/shell_layout_tests_android.h View 1 chunk +0 lines, -25 lines 0 comments Download
D content/shell/browser/shell_layout_tests_android.cc View 1 chunk +0 lines, -93 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mike West
WDYT, Peter?
6 years, 2 months ago (2014-10-16 12:31:38 UTC) #2
Peter Beverloo
lgtm
6 years, 2 months ago (2014-10-16 13:49:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661743002/20001
6 years, 2 months ago (2014-10-16 13:55:02 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-16 14:44:46 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 14:45:53 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d6805d0d1d21976cf16d0237d9091f7eebea4ea5
Cr-Commit-Position: refs/heads/master@{#299892}

Powered by Google App Engine
This is Rietveld 408576698