Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: tools/perf/measurements/loading_trace.py

Issue 661653003: telemetry: Delete loading measurement. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/measurements/loading_trace.py
diff --git a/tools/perf/measurements/loading_trace.py b/tools/perf/measurements/loading_trace.py
deleted file mode 100644
index 54752156e785f1334af63dfd62d2f60c26c7ab28..0000000000000000000000000000000000000000
--- a/tools/perf/measurements/loading_trace.py
+++ /dev/null
@@ -1,41 +0,0 @@
-# Copyright 2013 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-from measurements import timeline_controller
-from metrics import loading
-from metrics import timeline
-from telemetry.page import page_test
-from telemetry.web_perf import timeline_interaction_record as tir_module
-
-class LoadingTrace(page_test.PageTest):
- def __init__(self, *args, **kwargs):
- super(LoadingTrace, self).__init__(*args, **kwargs)
- self._timeline_controller = timeline_controller.TimelineController()
-
- def WillNavigateToPage(self, page, tab):
- self._timeline_controller.SetUp(page, tab)
- self._timeline_controller.Start(tab)
-
- def ValidateAndMeasurePage(self, page, tab, results):
- # In current telemetry tests, all tests wait for DocumentComplete state,
- # but we need to wait for the load event.
- tab.WaitForJavaScriptExpression('performance.timing.loadEventStart', 300)
-
- # TODO(nduca): when crbug.com/168431 is fixed, modify the page sets to
- # recognize loading as a toplevel action.
- self._timeline_controller.Stop(tab)
-
- loading.LoadingMetric().AddResults(tab, results)
- timeline_metric = timeline.LoadTimesTimelineMetric()
- renderer_thread = \
- self._timeline_controller.model.GetRendererThreadFromTabId(tab.id)
- record = tir_module.TimelineInteractionRecord(
- "loading_trace_interaction", 0, float('inf'))
- timeline_metric.AddResults(
- self._timeline_controller.model,
- renderer_thread,
- [record],
- results)
-
- def CleanUpAfterPage(self, _, tab):
- self._timeline_controller.CleanUp(tab)
« no previous file with comments | « tools/perf/measurements/loading_measurement_analyzer_unittest.py ('k') | tools/perf/measurements/loading_trace_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698