Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1555)

Unified Diff: Source/core/rendering/svg/RenderSVGResourceGradient.cpp

Issue 661643005: Pass more const RenderObject& in the vicinity of paint-servers (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: const RenderObject& Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/svg/RenderSVGResourceGradient.cpp
diff --git a/Source/core/rendering/svg/RenderSVGResourceGradient.cpp b/Source/core/rendering/svg/RenderSVGResourceGradient.cpp
index f4ba2e3b7c51bc7b126a0de723d6b6d0b07274fb..ca7a8b8a0f665e484d0e6b73b3c2f300e329308c 100644
--- a/Source/core/rendering/svg/RenderSVGResourceGradient.cpp
+++ b/Source/core/rendering/svg/RenderSVGResourceGradient.cpp
@@ -45,10 +45,8 @@ void RenderSVGResourceGradient::removeClientFromCache(RenderObject* client, bool
markClientForInvalidation(client, markForInvalidation ? PaintInvalidation : ParentOnlyInvalidation);
}
-SVGPaintServer RenderSVGResourceGradient::preparePaintServer(RenderObject* object)
+SVGPaintServer RenderSVGResourceGradient::preparePaintServer(const RenderObject& object)
{
- ASSERT(object);
-
clearInvalidationMask();
// Be sure to synchronize all SVG properties on the gradientElement _before_ processing any further.
@@ -69,11 +67,11 @@ SVGPaintServer RenderSVGResourceGradient::preparePaintServer(RenderObject* objec
// Spec: When the geometry of the applicable element has no width or height and objectBoundingBox is specified,
// then the given effect (e.g. a gradient or a filter) will be ignored.
- FloatRect objectBoundingBox = object->objectBoundingBox();
+ FloatRect objectBoundingBox = object.objectBoundingBox();
if (gradientUnits() == SVGUnitTypes::SVG_UNIT_TYPE_OBJECTBOUNDINGBOX && objectBoundingBox.isEmpty())
return SVGPaintServer::invalid();
- OwnPtr<GradientData>& gradientData = m_gradientMap.add(object, nullptr).storedValue->value;
+ OwnPtr<GradientData>& gradientData = m_gradientMap.add(&object, nullptr).storedValue->value;
if (!gradientData)
gradientData = adoptPtr(new GradientData);
« no previous file with comments | « Source/core/rendering/svg/RenderSVGResourceGradient.h ('k') | Source/core/rendering/svg/RenderSVGResourcePattern.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698