Pass more const RenderObject& in the vicinity of paint-servers

Pass more const RenderObject& in the vicinity of paint-servers

BUG=420022
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183882

[fs, 2014-10-16 12:08:00]

fs@opera.com changed reviewers:
+ fmalita@chromium.org, kouhei@chromium.org, pdr@chromium.org,
schenney@chromium.org

[kouhei (in TOK), 2014-10-16 12:30:26]

lgtm I like const, but I remember there was some discussion about "const
RenderObject" in paint team? Please wait for one more lgtm.

[fs, 2014-10-16 12:39:07]

On 2014/10/16 12:30:26, kouhei wrote:
> lgtm I like const, but I remember there was some discussion about "const
> RenderObject" in paint team? Please wait for one more lgtm.

Thanks! Yes, const has a tendency to be a bit contentious.

[pdr., 2014-10-16 18:58:40]

On 2014/10/16 at 12:39:07, fs wrote:
> On 2014/10/16 12:30:26, kouhei wrote:
> > lgtm I like const, but I remember there was some discussion about "const
> > RenderObject" in paint team? Please wait for one more lgtm.
> 
> Thanks! Yes, const has a tendency to be a bit contentious.

LGTM here as well. C++ is the worst language but these are examples of logical
constness. They help readability and help us catch errors at compile time when
possible.

Nit: I prefer to use const references as function parameters where possible. Up
to you though.

[fs, 2014-10-17 10:50:04]

On 2014/10/16 18:58:40, pdr wrote:
> On 2014/10/16 at 12:39:07, fs wrote:
> > On 2014/10/16 12:30:26, kouhei wrote:
> > > lgtm I like const, but I remember there was some discussion about "const
> > > RenderObject" in paint team? Please wait for one more lgtm.
> > 
> > Thanks! Yes, const has a tendency to be a bit contentious.
> 
> LGTM here as well. C++ is the worst language but these are examples of logical
> constness. They help readability and help us catch errors at compile time when
> possible.
> 
> Nit: I prefer to use const references as function parameters where possible.
Up
> to you though.

Yeah, I prefer them too - especially for code like "foo(const Bar* bourbon) {
ASSERT(bourbon); ... }". I'll see it works out (and without too much additional
stir.)

[fs, 2014-10-17 11:32:41]

On 2014/10/17 10:50:04, fs wrote:
> On 2014/10/16 18:58:40, pdr wrote:
> > On 2014/10/16 at 12:39:07, fs wrote:
> > > On 2014/10/16 12:30:26, kouhei wrote:
> > > > lgtm I like const, but I remember there was some discussion about "const
> > > > RenderObject" in paint team? Please wait for one more lgtm.
> > > 
> > > Thanks! Yes, const has a tendency to be a bit contentious.
> > 
> > LGTM here as well. C++ is the worst language but these are examples of
logical
> > constness. They help readability and help us catch errors at compile time
when
> > possible.
> > 
> > Nit: I prefer to use const references as function parameters where possible.
> Up
> > to you though.
> 
> Yeah, I prefer them too - especially for code like "foo(const Bar* bourbon) {
> ASSERT(bourbon); ... }". I'll see it works out (and without too much
additional
> stir.)

Done. No major fallout (did get rid of an ugly-looking const_cast though =)).

[fs, 2014-10-17 11:32:48]

The CQ bit was checked by fs@opera.com

[fs, 2014-10-17 11:32:51]

The CQ bit was unchecked by fs@opera.com

[fs, 2014-10-17 11:33:27]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2014-10-17 11:33:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/661643005/20001

[commit-bot: I haz the power, 2014-10-17 12:29:36]

Committed patchset #2 (id:20001) as 183882