Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2362)

Unified Diff: chrome/browser/notifications/platform_notification_service_impl.h

Issue 661643002: Adds a context message of the security origin for web notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/platform_notification_service_impl.h
diff --git a/chrome/browser/notifications/platform_notification_service_impl.h b/chrome/browser/notifications/platform_notification_service_impl.h
index 82bf1e4a2c6ace2fee125748dc5b1db8706684ce..2c2484303751c285486858de5789c537b728da6b 100644
--- a/chrome/browser/notifications/platform_notification_service_impl.h
+++ b/chrome/browser/notifications/platform_notification_service_impl.h
@@ -60,15 +60,13 @@ class PlatformNotificationServiceImpl
const SkBitmap& icon,
const content::PlatformNotificationData& notification_data,
scoped_ptr<content::DesktopNotificationDelegate> delegate,
- int render_process_id,
base::Closure* cancel_callback) override;
void DisplayPersistentNotification(
content::BrowserContext* browser_context,
int64 service_worker_registration_id,
const GURL& origin,
const SkBitmap& icon,
- const content::PlatformNotificationData& notification_data,
- int render_process_id) override;
+ const content::PlatformNotificationData& notification_data) override;
void ClosePersistentNotification(
content::BrowserContext* browser_context,
const std::string& persistent_notification_id) override;
@@ -80,6 +78,8 @@ class PlatformNotificationServiceImpl
friend class gcm::PushMessagingBrowserTest;
FRIEND_TEST_ALL_PREFIXES(
PlatformNotificationServiceTest, DisplayNameForOrigin);
+ FRIEND_TEST_ALL_PREFIXES(PlatformNotificationServiceTest,
+ TestWebOriginDisplayName);
PlatformNotificationServiceImpl();
~PlatformNotificationServiceImpl() override;
@@ -92,19 +92,24 @@ class PlatformNotificationServiceImpl
const GURL& origin,
const SkBitmap& icon,
const content::PlatformNotificationData& notification_data,
- NotificationDelegate* delegate,
- int render_process_id) const;
+ NotificationDelegate* delegate) const;
// Overrides the Notification UI Manager to use to |manager|. Only to be
// used by tests. Tests are responsible for cleaning up after themselves.
void SetNotificationUIManagerForTesting(NotificationUIManager* manager);
- // Returns a display name for an origin in the process id, to be used in
- // permission infobar or on the frame of the notification toast. Different
- // from the origin itself when dealing with extensions.
- base::string16 DisplayNameForOriginInProcessId(Profile* profile,
- const GURL& origin,
- int process_id) const;
+ // Returns a display name for an origin, to be used in permission infobar or
+ // on the frame of the notification toast. Different from the origin itself
+ // when dealing with extensions.
+ base::string16 DisplayNameForOrigin(Profile* profile,
+ const GURL& origin) const;
+
+ // Translates a URL into a slightly more readable version that may omit
+ // the port and scheme for common cases.
+ // TODO(dewittj): Remove this when the proper function is implemented in a
+ // chrome/browser/ui library function. See crbug.com/402698.
+ static base::string16 WebOriginDisplayName(const GURL& origin,
+ const std::string& languages);
// Weak reference. Ownership maintains with the test.
NotificationUIManager* notification_ui_manager_for_tests_;

Powered by Google App Engine
This is Rietveld 408576698