content/browser/notifications/notification_message_filter.cc - Issue 661643002: Adds a context message of the security origin for web notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/notifications/notification_message_filter.cc

Issue 661643002: Adds a context message of the security origin for web notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/notifications/platform_notification_service_impl.cc ('K') | « chrome/browser/services/gcm/push_messaging_service_impl.cc ('k') | content/public/browser/platform_notification_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/notifications/notification_message_filter.cc

diff --git a/content/browser/notifications/notification_message_filter.cc b/content/browser/notifications/notification_message_filter.cc

index 537e90a25d1ca56a521b912e50c4acdf35a27a8f..ee4392592f9caa99e934462ee01a3529ca854019 100644

--- a/content/browser/notifications/notification_message_filter.cc

+++ b/content/browser/notifications/notification_message_filter.cc

@@ -93,7 +93,6 @@ void NotificationMessageFilter::OnShowPlatformNotification(

icon,

notification_data,

delegate.Pass(),

- process_id_,

&close_closure);

if (!close_closure.is_null())

@@ -114,11 +113,8 @@ void NotificationMessageFilter::OnShowPersistentNotification(

// TODO(peter): Verify that permission has been granted for |origin|.

service->DisplayPersistentNotification(browser_context_,

- service_worker_registration_id,

- origin,

- icon,

- notification_data,

- process_id_);

+ service_worker_registration_id, origin,

+ icon, notification_data);

}

void NotificationMessageFilter::OnClosePlatformNotification(