Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: chrome/browser/notifications/platform_notification_service_unittest.cc

Issue 661643002: Adds a context message of the security origin for web notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix merge error. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/platform_notification_service_unittest.cc
diff --git a/chrome/browser/notifications/platform_notification_service_unittest.cc b/chrome/browser/notifications/platform_notification_service_unittest.cc
index 32f2546677dc9713b8199b9ad929493173d8ba48..1da86b07aaea36cb6b0b5379703c730283da674a 100644
--- a/chrome/browser/notifications/platform_notification_service_unittest.cc
+++ b/chrome/browser/notifications/platform_notification_service_unittest.cc
@@ -190,6 +190,47 @@ TEST_F(PlatformNotificationServiceTest, DisplayNameForOrigin) {
// functionality of DisplayNameForOriginInProcessId.
}
+TEST_F(PlatformNotificationServiceTest, TestOriginDisplayName) {
+ std::string language("en-us");
+
+ GURL https_origin("https://mail.google.com/");
+ base::string16 expected_display_name = base::ASCIIToUTF16("mail.google.com");
+ EXPECT_EQ(expected_display_name,
+ PlatformNotificationServiceImpl::OriginDisplayName(https_origin,
+ language));
+
+ GURL https_origin_standard_port("https://mail.google.com:443/");
+ expected_display_name = base::ASCIIToUTF16("mail.google.com");
+ EXPECT_EQ(expected_display_name,
+ PlatformNotificationServiceImpl::OriginDisplayName(
+ https_origin_standard_port, language));
+
+ GURL https_origin_nonstandard_port("https://mail.google.com:444/");
+ expected_display_name = base::ASCIIToUTF16("mail.google.com:444");
+ EXPECT_EQ(expected_display_name,
+ PlatformNotificationServiceImpl::OriginDisplayName(
+ https_origin_nonstandard_port, language));
+
+ GURL http_origin("http://mail.google.com/");
+ expected_display_name = base::ASCIIToUTF16("mail.google.com");
+ EXPECT_EQ(expected_display_name,
+ PlatformNotificationServiceImpl::OriginDisplayName(http_origin,
+ language));
+
+ GURL http_origin_standard_port("http://mail.google.com:80/");
+ expected_display_name = base::ASCIIToUTF16("mail.google.com");
+ EXPECT_EQ(expected_display_name,
+ PlatformNotificationServiceImpl::OriginDisplayName(
+ http_origin_standard_port, language));
+
+ GURL http_origin_nonstandard_port("http://mail.google.com:81/");
+ expected_display_name = base::ASCIIToUTF16("mail.google.com:81");
+ EXPECT_EQ(expected_display_name,
+ PlatformNotificationServiceImpl::OriginDisplayName(
+ http_origin_nonstandard_port, language));
+ // TODO(dewittj): Add file origin once it's supported.
+}
+
TEST_F(PlatformNotificationServiceTest, NotificationPermissionLastUsage) {
// Both page and persistent notifications should update the last usage
// time of the notification permission for the origin.

Powered by Google App Engine
This is Rietveld 408576698