Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 661633003: Get rid of slow repaint objects and main thread scrolling reasons. (Closed)

Created:
6 years, 1 month ago by ojan
Modified:
6 years, 1 month ago
Reviewers:
esprehn
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Get rid of slow repaint objects and main thread scrolling reasons. We will only have one scrolling path in Sky, so we don't need machinery for mutiple scrolling codepaths. Remove viewportConstrained plumbing. Sky doesn't have viewport constrained elements (no position:fixed). R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/feae413a48ceb8c33d4fd500ac74016ad59e03fc

Patch Set 1 #

Patch Set 2 : merge to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -207 lines) Patch
M sky/engine/core/frame/FrameView.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 1 2 chunks +0 lines, -23 lines 0 comments Download
M sky/engine/core/page/Page.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/page/Page.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M sky/engine/core/page/scrolling/ScrollingCoordinator.h View 1 6 chunks +0 lines, -29 lines 0 comments Download
M sky/engine/core/page/scrolling/ScrollingCoordinator.cpp View 1 7 chunks +1 line, -97 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 1 chunk +0 lines, -31 lines 0 comments Download
M sky/engine/core/rendering/compositing/RenderLayerCompositor.cpp View 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ojan
6 years, 1 month ago (2014-10-28 21:51:06 UTC) #2
esprehn
lgtm
6 years, 1 month ago (2014-10-28 21:55:20 UTC) #3
ojan
6 years, 1 month ago (2014-10-28 21:57:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
feae413a48ceb8c33d4fd500ac74016ad59e03fc.

Powered by Google App Engine
This is Rietveld 408576698