Issue 661633003: Get rid of slow repaint objects and main thread scrolling reasons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 661633003: Get rid of slow repaint objects and main thread scrolling reasons. (Closed)

Created:
6 years, 1 month ago by ojan

Modified:
6 years, 1 month ago

Reviewers:
esprehn

CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Get rid of slow repaint objects and main thread scrolling reasons. We will only have one scrolling path in Sky, so we don't need machinery for mutiple scrolling codepaths. Remove viewportConstrained plumbing. Sky doesn't have viewport constrained elements (no position:fixed). R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/feae413a48ceb8c33d4fd500ac74016ad59e03fc

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -207 lines)			Patch
M	sky/engine/core/frame/FrameView.h	View	1	2 chunks	+0 lines, -5 lines	0 comments	Download
M	sky/engine/core/frame/FrameView.cpp	View	1	2 chunks	+0 lines, -23 lines	0 comments	Download
M	sky/engine/core/page/Page.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/core/page/Page.cpp	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	sky/engine/core/page/scrolling/ScrollingCoordinator.h	View	1	6 chunks	+0 lines, -29 lines	0 comments	Download
M	sky/engine/core/page/scrolling/ScrollingCoordinator.cpp	View	1	7 chunks	+1 line, -97 lines	0 comments	Download
M	sky/engine/core/rendering/RenderObject.cpp	View		1 chunk	+0 lines, -31 lines	0 comments	Download
M	sky/engine/core/rendering/compositing/RenderLayerCompositor.cpp	View		2 chunks	+0 lines, -13 lines	0 comments	Download

Total messages: 4 (1 generated)

ojan

6 years, 1 month ago (2014-10-28 21:57:43 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
feae413a48ceb8c33d4fd500ac74016ad59e03fc.