Fix disable_nacl=1 build.

Fix disable_nacl=1 build.

This was broken in https://codereview.chromium.org/61763014: gyp complains that
native_client_sdk/native_client_sdk_untrusted.gyp, included from build/all.gyp,
has no targets.

BUG=319174
R=binji@chromium.org, jochen@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235114

[Joao da Silva, 2013-11-14 08:03:02]

Jochen, please have a look. I'm not sure this is the right way to fix this kind
of gyp issue; chrome/installer/mini_installer_syzygy.gyp has a similar fix FWIW.

https://codereview.chromium.org/66163013/diff/1/chrome/installer/mini_install...
File chrome/installer/mini_installer_syzygy.gyp (right):

https://codereview.chromium.org/66163013/diff/1/chrome/installer/mini_install...
chrome/installer/mini_installer_syzygy.gyp:65: 'targets': [],
This looks like the same issue

[jochen (gone - plz use gerrit), 2013-11-14 08:12:20]

i think the right fix is that all.gyp doesn't depend on the native client file.
it doesn't depend on anything else from native client either.

[binji, 2013-11-14 08:31:55]

On 2013/11/14 08:12:20, jochen wrote:
> i think the right fix is that all.gyp doesn't depend on the native client
file.
> it doesn't depend on anything else from native client either.

sgtm, I assumed this would work properly with disable_nacl. Feel free to remove
from all.gyp

[Joao da Silva, 2013-11-14 08:34:14]

Done, PTAL

[binji, 2013-11-14 08:36:11]

lgtm

[jochen (gone - plz use gerrit), 2013-11-14 08:54:58]

lgtm

https://codereview.chromium.org/66163013/diff/70001/chrome/installer/mini_ins...
File chrome/installer/mini_installer_syzygy.gyp (right):

https://codereview.chromium.org/66163013/diff/70001/chrome/installer/mini_ins...
chrome/installer/mini_installer_syzygy.gyp:64: }, {
can you remove this whitespace change from your cl?

[Joao da Silva, 2013-11-14 08:56:26]

https://codereview.chromium.org/66163013/diff/70001/chrome/installer/mini_ins...
File chrome/installer/mini_installer_syzygy.gyp (right):

https://codereview.chromium.org/66163013/diff/70001/chrome/installer/mini_ins...
chrome/installer/mini_installer_syzygy.gyp:64: }, {
On 2013/11/14 08:54:58, jochen wrote:
> can you remove this whitespace change from your cl?

Done.

[Joao da Silva, 2013-11-14 10:15:08]

Committed patchset #3 manually as r235114.

[Peter Lundblad, 2013-11-14 16:21:03]

Hey, sorry for that and thanks for fixing!

Regards,
//Peter


joaodasilva@chromium.org writes:
> Committed patchset #3 manually as r235114.
> 
> https://codereview.chromium.org/66163013/

-- 

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.