Issue 66163003: Reland "Implement Math.sin, cos and tan using table lookup and spline interpolation.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 66163003: Reland "Implement Math.sin, cos and tan using table lookup and spline interpolation."" (Closed)

Created:
7 years, 1 month ago by Yang

Modified:
7 years, 1 month ago

Reviewers:
Sven Panne, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Reland "Implement Math.sin, cos and tan using table lookup and spline interpolation." This relands r17594. BUG=

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+270 lines, -229 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	1 2	1 chunk	+0 lines, -36 lines	0 comments	Download
M	src/hydrogen.cc	View	1 2	5 chunks	+6 lines, -37 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	1 2	1 chunk	+0 lines, -36 lines	0 comments	Download
M	src/math.js	View	1 2	5 chunks	+94 lines, -3 lines	0 comments	Download
M	src/mips/full-codegen-mips.cc	View		2 chunks	+7 lines, -36 lines	0 comments	Download
M	src/objects.h	View	1 2	4 chunks	+7 lines, -3 lines	0 comments	Download
M	src/objects.cc	View	1 2	2 chunks	+10 lines, -14 lines	0 comments	Download
M	src/objects-inl.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	src/runtime.h	View	1 2	3 chunks	+2 lines, -3 lines	0 comments	Download
M	src/runtime.cc	View	1 2	2 chunks	+43 lines, -0 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	1 2	1 chunk	+0 lines, -36 lines	0 comments	Download
M	test/mjsunit/constant-folding-2.js	View	1 2	1 chunk	+0 lines, -24 lines	0 comments	Download
M	test/mjsunit/sin-cos.js	View	1	1 chunk	+94 lines, -1 line	0 comments	Download
M	test/mozilla/mozilla.status	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	test/test262/test262.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Yang

Please take a look. First patch set is the reverted CL. Second patch set contains ...

7 years, 1 month ago (2013-11-08 16:06:23 UTC) #1

NOT LGTM. Read the spec, Luke...