Issue 661613004: bug_chomper: Cleanup template initialization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 661613004: bug_chomper: Cleanup template initialization. (Closed)

Created:
6 years, 2 months ago by tfarina

Modified:
6 years, 2 months ago

Reviewers:
borenet

CC:
reviews_skia.org, jcgregorio

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

bug_chomper: Cleanup template initialization. Use the same tricks used by webtry and perf. Code seems more robust and easier to check for errors this way. BUG=None TEST=./run_server.sh, then navigate to 127.0.0.1:8000 and 127.0.0.1:8000/res R=borenet@google.com Committed: https://skia.googlesource.com/skia/+/3f752205a5d55b47c2d07486736c5e344b45a017

Patch Set 1 #

Total comments: 1

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -10 lines)			Patch
	M	tools/bug_chomper/src/server/server.go	View		3 chunks	+22 lines, -10 lines	1 comment	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

tfarina

Is this OK? https://codereview.chromium.org/661613004/diff/1/tools/bug_chomper/src/server/server.go File tools/bug_chomper/src/server/server.go (right): https://codereview.chromium.org/661613004/diff/1/tools/bug_chomper/src/server/server.go#newcode72 tools/bug_chomper/src/server/server.go:72: filepath.Join(cwd, "templates/bug_chomper.html"), cwd results in the ...

6 years, 2 months ago (2014-10-15 22:18:14 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661613004/1

6 years, 2 months ago (2014-10-17 21:18:02 UTC) #4

commit-bot: I haz the power

6 years, 2 months ago (2014-10-17 21:25:23 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 3f752205a5d55b47c2d07486736c5e344b45a017

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages