Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 661613003: Fix telemetry tests that run against the data reduction dev proxy. (Closed)

Created:
6 years, 2 months ago by sclittle
Modified:
6 years, 2 months ago
Reviewers:
bengr, bolian
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix telemetry tests that run against the data reduction dev proxy. Currently, the data reduction proxy telemetry tests expect that the dev proxy string will include the scheme of the URL, but it actually doesn't. This CL changes the tests to not expect the scheme in the dev proxy URL. BUG=423916 Committed: https://crrev.com/3919c2090e2125ae7219d428e7bd2700c5b4b21f Cr-Commit-Position: refs/heads/master@{#299817}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py View 1 4 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
sclittle
bolian, bengr: all Thanks in advance!
6 years, 2 months ago (2014-10-15 21:48:14 UTC) #2
bolian
On 2014/10/15 21:48:14, sclittle wrote: > bolian, bengr: all > > Thanks in advance! I ...
6 years, 2 months ago (2014-10-15 21:51:31 UTC) #3
bengr
https://codereview.chromium.org/661613003/diff/1/tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py File tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py (right): https://codereview.chromium.org/661613003/diff/1/tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py#newcode23 tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py:23: PROXY_DEV_SETTING_HTTPS = 'proxy-dev.googlezip.net:80' Shouldn't this be PROXY_DEV_SETTING_HTTP?
6 years, 2 months ago (2014-10-15 21:52:26 UTC) #4
sclittle
On 2014/10/15 21:51:31, bolian wrote: > On 2014/10/15 21:48:14, sclittle wrote: > > bolian, bengr: ...
6 years, 2 months ago (2014-10-15 22:20:42 UTC) #5
sclittle
https://codereview.chromium.org/661613003/diff/1/tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py File tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py (right): https://codereview.chromium.org/661613003/diff/1/tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py#newcode23 tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py:23: PROXY_DEV_SETTING_HTTPS = 'proxy-dev.googlezip.net:80' On 2014/10/15 21:52:26, bengr1 wrote: > ...
6 years, 2 months ago (2014-10-15 22:31:12 UTC) #6
bengr
lgtm
6 years, 2 months ago (2014-10-15 22:43:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661613003/20001
6 years, 2 months ago (2014-10-16 00:42:43 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-16 02:01:38 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 02:02:41 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3919c2090e2125ae7219d428e7bd2700c5b4b21f
Cr-Commit-Position: refs/heads/master@{#299817}

Powered by Google App Engine
This is Rietveld 408576698