Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issue 661613002: Remove gpu bots from sub-directory PRESUBMITs. (Closed)

Created:
6 years, 2 months ago by danakj
Modified:
6 years, 2 months ago
CC:
chromium-reviews, cc-bugs_chromium.org, robertphillips
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove gpu bots from sub-directory PRESUBMITs. These bots should run when required by our top-level detection of what bots are needed. And the GPU bots are in the default sets of bots now. Committed: https://crrev.com/cad175bcb2dec50bc1215a664abc5b179d585657 Cr-Commit-Position: refs/heads/master@{#299799}

Patch Set 1 #

Patch Set 2 : bots: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -28 lines) Patch
M cc/PRESUBMIT.py View 1 1 chunk +0 lines, -5 lines 0 comments Download
D skia/PRESUBMIT.py View 1 1 chunk +0 lines, -5 lines 0 comments Download
D ui/gl/PRESUBMIT.py View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 15 (3 generated)
danakj
6 years, 2 months ago (2014-10-15 20:57:20 UTC) #2
danakj
Oh src/PRESUBMIT doesn't do blink bots yet, so leaving those, just removing gpu bots.
6 years, 2 months ago (2014-10-15 20:59:40 UTC) #3
no sievers
+kbr just to double-check but I believe you so lgtm :)
6 years, 2 months ago (2014-10-15 21:01:46 UTC) #5
Stephen White
Not sure about the skia changes: I think this should always trigger linux_blink_rel on Skia ...
6 years, 2 months ago (2014-10-15 21:06:39 UTC) #6
borenet
On 2014/10/15 21:06:39, Stephen White wrote: > Not sure about the skia changes: I think ...
6 years, 2 months ago (2014-10-15 21:09:40 UTC) #7
danakj
On 2014/10/15 21:09:40, borenet wrote: > On 2014/10/15 21:06:39, Stephen White wrote: > > Not ...
6 years, 2 months ago (2014-10-15 22:11:10 UTC) #8
danakj
On 2014/10/15 22:11:10, danakj wrote: > On 2014/10/15 21:09:40, borenet wrote: > > On 2014/10/15 ...
6 years, 2 months ago (2014-10-15 22:12:07 UTC) #9
Ken Russell (switch to Gerrit)
Yes, these are in the default set of bots now. LGTM
6 years, 2 months ago (2014-10-15 23:30:01 UTC) #10
Stephen White
LGTM too. Thanks for the clarification.
6 years, 2 months ago (2014-10-16 00:10:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661613002/20001
6 years, 2 months ago (2014-10-16 00:42:41 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-16 00:57:14 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 00:58:11 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cad175bcb2dec50bc1215a664abc5b179d585657
Cr-Commit-Position: refs/heads/master@{#299799}

Powered by Google App Engine
This is Rietveld 408576698