Fix re-opening Chrome after the last active profile was a Guest profile.

Fix re-opening Chrome after the last active profile was a Guest profile.

BUG=423049
TEST=Start Chrome with an empty user data dir and --enable-new-avatar-menu.
From the avatar menu, click on "Switch Person", and "Browse as Guest" from
the user manager. Without closing any of the profile windows, choose "Exit"
from the Guest profile's hot dog menu. Restart Chrome. It should start up
and reopen the previous non-guest opened profile.

Committed: https://crrev.com/71f71a0dbb70e2072ef15efb44c4997d58bf960d
Cr-Commit-Position: refs/heads/master@{#300153}

[noms (inactive), 2014-10-16 17:45:25]

noms@chromium.org changed reviewers:
+ sky@chromium.org

[noms (inactive), 2014-10-16 17:45:26]

Hi Scott,

This fixes the Chrome startup code to deal better with the last active profile
being a Guest profile. Please take a look. Thanks!

[sky, 2014-10-16 19:51:12]

https://codereview.chromium.org/661603007/diff/1/chrome/browser/ui/startup/st...
File chrome/browser/ui/startup/startup_browser_creator.cc (left):

https://codereview.chromium.org/661603007/diff/1/chrome/browser/ui/startup/st...
chrome/browser/ui/startup/startup_browser_creator.cc:667: if
(switches::IsNewAvatarMenu() &&
Can't this still happen?

https://codereview.chromium.org/661603007/diff/1/chrome/browser/ui/startup/st...
File chrome/browser/ui/startup/startup_browser_creator.cc (right):

https://codereview.chromium.org/661603007/diff/1/chrome/browser/ui/startup/st...
chrome/browser/ui/startup/startup_browser_creator.cc:653: last_used_profile =
last_opened_profiles[0];
How do you know last_opened_profiles isn't a guest?

[noms (inactive), 2014-10-16 19:57:05]

https://codereview.chromium.org/661603007/diff/1/chrome/browser/ui/startup/st...
File chrome/browser/ui/startup/startup_browser_creator.cc (left):

https://codereview.chromium.org/661603007/diff/1/chrome/browser/ui/startup/st...
chrome/browser/ui/startup/startup_browser_creator.cc:667: if
(switches::IsNewAvatarMenu() &&
On 2014/10/16 19:51:12, sky wrote:
> Can't this still happen?

No, since none of the profiles in last_opened_profiles can be Guest. I can add a
DCHECK, or even leave it in, but I don't think it would ever be true.

Actually, a DCHECK at the top would be really comforting, so I'll add that.

https://codereview.chromium.org/661603007/diff/1/chrome/browser/ui/startup/st...
File chrome/browser/ui/startup/startup_browser_creator.cc (right):

https://codereview.chromium.org/661603007/diff/1/chrome/browser/ui/startup/st...
chrome/browser/ui/startup/startup_browser_creator.cc:653: last_used_profile =
last_opened_profiles[0];
On 2014/10/16 19:51:12, sky wrote:
> How do you know last_opened_profiles isn't a guest?

Only non-off-the-record profiles are added to the ProfileManager's list of
active profiles (which is where last_opened_profiles comes from), and the Guest
profile is off the record:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/pro...

[sky, 2014-10-16 20:01:32]

Ok, LGTM

[noms (inactive), 2014-10-17 19:10:58]

The CQ bit was checked by noms@chromium.org

[commit-bot: I haz the power, 2014-10-17 19:11:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/661603007/40001

[commit-bot: I haz the power, 2014-10-17 20:10:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-17 20:12:07]

Patchset 3 (id:??) landed as
https://crrev.com/71f71a0dbb70e2072ef15efb44c4997d58bf960d
Cr-Commit-Position: refs/heads/master@{#300153}