Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 6616001: theme: Unbind Ctrl-Shift-Backspace in GtkUndoView. (Closed)

Created:
8 years, 5 months ago by Daniel Erat
Modified:
8 years, 3 months ago
Reviewers:
falken
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

theme: Unbind Ctrl-Shift-Backspace in GtkUndoView. I'm changing Chrome's "Clear Browsing Data" accelerator to Ctrl-Shift-Backspace, so this change tells GTK+ to unbind that instead of Ctrl-Shift-Delete. This change makes the "Clear Browsing Data" accelerator work when the focus is in the omnibox, while still honoring the "delete to the beginning of the line" accelerator when the focus is in e.g. a textarea. BUG=chromium-os:11137 TEST=manual: check that the dialog is opened when i hit ctrl-shift-backspace while the focus is in the omnibox or in a non-editable part of a web page, and that the text-editing accelerator works when the focus is in a textarea Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=69c4bb6

Patch Set 1 #

Patch Set 2 : un-revert a helpful comment i'd added #

Patch Set 3 : unbind ctrl-shift-backspace instead #

Patch Set 4 : limit scope of unbinding to GtkUndoView #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M resources/gtkrc View 1 2 3 2 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Daniel Erat
8 years, 5 months ago (2011-03-03 02:14:06 UTC) #1
falken
8 years, 5 months ago (2011-03-03 02:20:11 UTC) #2
LGTM.

On 2011/03/03 02:14:06, Daniel Erat wrote:

Powered by Google App Engine
This is Rietveld 408576698