Issue 6616001: theme: Unbind Ctrl-Shift-Backspace in GtkUndoView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6616001: theme: Unbind Ctrl-Shift-Backspace in GtkUndoView. (Closed)

Created:
9 years, 9 months ago by Daniel Erat

Modified:
9 years, 7 months ago

Reviewers:
falken

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@gitrw.chromium.org:9222/theme.git@master

Visibility:
Public.

Description

theme: Unbind Ctrl-Shift-Backspace in GtkUndoView. I'm changing Chrome's "Clear Browsing Data" accelerator to Ctrl-Shift-Backspace, so this change tells GTK+ to unbind that instead of Ctrl-Shift-Delete. This change makes the "Clear Browsing Data" accelerator work when the focus is in the omnibox, while still honoring the "delete to the beginning of the line" accelerator when the focus is in e.g. a textarea. BUG=chromium-os:11137 TEST=manual: check that the dialog is opened when i hit ctrl-shift-backspace while the focus is in the omnibox or in a non-editable part of a web page, and that the text-editing accelerator works when the focus is in a textarea Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=69c4bb6

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -7 lines)			Patch
	M	resources/gtkrc	View	1 2 3	2 chunks	+8 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

On 2011/03/03 02:14:06, Daniel Erat wrote:

Expand Messages | Collapse Messages

Issue 6616001: theme: Unbind Ctrl-Shift-Backspace in GtkUndoView. (Closed)

Description

Patch Set 1 #

Patch Set 2 : un-revert a helpful comment i'd added #

Patch Set 3 : unbind ctrl-shift-backspace instead #

Patch Set 4 : limit scope of unbinding to GtkUndoView #

Messages