Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 661593005: Build a few more extensions files only when extensions are enabled. (Closed)

Created:
6 years, 2 months ago by Lei Zhang
Modified:
6 years, 2 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Build a few more extensions files only when extensions are enabled. Also move a class implementation out of feature_channel.h. BUG=424746 Committed: https://crrev.com/f55539c55ab085f862b32ad26df420b0b0c1d7a4 Cr-Commit-Position: refs/heads/master@{#300343}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -23 lines) Patch
M chrome/chrome_browser.gypi View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/chrome_common.gypi View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/common/extensions/features/feature_channel.h View 1 chunk +4 lines, -9 lines 0 comments Download
M chrome/common/extensions/features/feature_channel.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Lei Zhang
6 years, 2 months ago (2014-10-17 23:41:21 UTC) #2
Yoyo Zhou
LGTM
6 years, 2 months ago (2014-10-20 20:55:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661593005/1
6 years, 2 months ago (2014-10-20 20:58:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-20 21:50:53 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 21:51:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f55539c55ab085f862b32ad26df420b0b0c1d7a4
Cr-Commit-Position: refs/heads/master@{#300343}

Powered by Google App Engine
This is Rietveld 408576698