Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 661593002: Annotate another GTK leak. (Closed)

Created:
6 years, 2 months ago by earthdok
Modified:
6 years, 2 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Annotate another GTK leak. BUG=423873 R=erg@chromium.org Committed: https://crrev.com/b0d96cbbd1ea1258eed3583f9209dd5a72018706 Cr-Commit-Position: refs/heads/master@{#299761}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/browser/ui/libgtk2ui/gtk2_util.cc View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
earthdok
Please take a look. This affects potential other users of CommonInitFromCommandLine (of which currently there ...
6 years, 2 months ago (2014-10-15 20:13:16 UTC) #1
Elliot Glaysher
lgtm
6 years, 2 months ago (2014-10-15 20:27:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661593002/1
6 years, 2 months ago (2014-10-15 20:30:47 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-15 20:59:32 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 21:00:20 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0d96cbbd1ea1258eed3583f9209dd5a72018706
Cr-Commit-Position: refs/heads/master@{#299761}

Powered by Google App Engine
This is Rietveld 408576698