Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 661583004: Revert "Limit the number of transitions allowed per hidden class." Due to crashes in ClearMapTransi… (Closed)

Created:
6 years, 1 month ago by Toon Verwaest
Modified:
6 years, 1 month ago
Reviewers:
Igor Sheludko, mckev
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Revert "Limit the number of transitions allowed per hidden class." Due to crashes in ClearMapTransitions BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24900

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -112 lines) Patch
M src/heap/mark-compact.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/objects.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M src/objects-inl.h View 2 chunks +3 lines, -10 lines 0 comments Download
M src/transitions.h View 6 chunks +13 lines, -35 lines 0 comments Download
M src/transitions.cc View 4 chunks +24 lines, -43 lines 0 comments Download
M src/transitions-inl.h View 1 chunk +0 lines, -9 lines 0 comments Download
M test/cctest/test-heap.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Toon Verwaest
PTAL
6 years, 1 month ago (2014-10-27 11:55:09 UTC) #2
Igor Sheludko
lgtm
6 years, 1 month ago (2014-10-27 11:56:18 UTC) #3
Toon Verwaest
6 years, 1 month ago (2014-10-27 11:58:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24900 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698