Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 661563002: Add does_storage_object_exist to gs_utils (Closed)

Created:
6 years, 2 months ago by borenet
Modified:
6 years, 2 months ago
Reviewers:
rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/common.git@master
Project:
skiacommon
Visibility:
Public.

Description

Add does_storage_object_exist to gs_utils Needed for recreate_skps script BUG=skia:3008 Committed: https://skia.googlesource.com/common/+/5eee100abacd0c2fc89121418627cf55ca2eda31

Patch Set 1 #

Patch Set 2 : fixes #

Patch Set 3 : Work harder to find .boto #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -7 lines) Patch
M .gitignore View 1 1 chunk +1 line, -1 line 1 comment Download
M py/utils/gs_utils.py View 1 2 4 chunks +32 lines, -6 lines 2 comments Download
M py/utils/gs_utils_manualtest.py View 1 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
borenet
https://codereview.chromium.org/661563002/diff/40001/.gitignore File .gitignore (right): https://codereview.chromium.org/661563002/diff/40001/.gitignore#newcode2 .gitignore:2: third_party/externals boto was showing up in "git status".
6 years, 2 months ago (2014-10-16 17:02:19 UTC) #2
rmistry
LGTM https://codereview.chromium.org/661563002/diff/40001/py/utils/gs_utils.py File py/utils/gs_utils.py (right): https://codereview.chromium.org/661563002/diff/40001/py/utils/gs_utils.py#newcode149 py/utils/gs_utils.py:149: if not boto_file_path: Remove this if since you ...
6 years, 2 months ago (2014-10-16 18:09:59 UTC) #3
borenet
https://codereview.chromium.org/661563002/diff/40001/py/utils/gs_utils.py File py/utils/gs_utils.py (right): https://codereview.chromium.org/661563002/diff/40001/py/utils/gs_utils.py#newcode149 py/utils/gs_utils.py:149: if not boto_file_path: On 2014/10/16 18:09:58, rmistry wrote: > ...
6 years, 2 months ago (2014-10-16 18:12:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661563002/40001
6 years, 2 months ago (2014-10-16 18:22:25 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 18:22:41 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as 5eee100abacd0c2fc89121418627cf55ca2eda31

Powered by Google App Engine
This is Rietveld 408576698