Issue 661543002: Remove unused NeedsDeepCopy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 661543002: Remove unused NeedsDeepCopy. (Closed)

Created:
6 years, 2 months ago by scroggo

Modified:
6 years, 2 months ago

Reviewers:
mtklein, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Remove unused NeedsDeepCopy. It was used to check to see if an SkPaint had mutable fields on it. Now that all the fields are immutable, this function is no longer used. Remove it. BUG=skia:2097 Committed: https://skia.googlesource.com/skia/+/80a720eb823ac76fdfa254fe9b9f7333a1458e5c

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -18 lines)			Patch
	M	src/core/SkPaintPriv.h	View		1 chunk	+0 lines, -7 lines	0 comments	Download
	M	src/core/SkPaintPriv.cpp	View		1 chunk	+0 lines, -11 lines	0 comments	Download

Total messages: 8 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661543002/1

6 years, 2 months ago (2014-10-15 18:33:59 UTC) #6

commit-bot: I haz the power

6 years, 2 months ago (2014-10-15 20:43:42 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 80a720eb823ac76fdfa254fe9b9f7333a1458e5c