Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 661513002: [Mojo] mojo_native_viewport_service should use "--" args (Closed)

Created:
6 years, 2 months ago by abarth-chromium
Modified:
6 years, 2 months ago
Reviewers:
hansmuller, DaveMoore
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Mojo] mojo_native_viewport_service should use "--" args I expected the mojo_native_viewport_service to use -- as a prefix for its arguments: mojo_shell --args-for="mojo://mojo_native_viewport_service/ --use-headless-config" but prior to this CL, it was expect its arguments without the leading "--". After this CL, it expects the leading "--". R=davemoore@chromium.org,hansmuller@chromium.org Committed: https://crrev.com/5acd9fe37eae1ff654eb195960d30be0fa55f03f Cr-Commit-Position: refs/heads/master@{#299810}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M mojo/services/public/cpp/native_viewport/lib/args.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
abarth-chromium
6 years, 2 months ago (2014-10-15 16:56:46 UTC) #1
hansmuller
On 2014/10/15 16:56:46, abarth wrote: This change LGTM. Perhaps native_viewport/main.cc should create a base::CommandLine from ...
6 years, 2 months ago (2014-10-15 20:07:03 UTC) #2
DaveMoore
On 2014/10/15 20:07:03, hansmuller wrote: > On 2014/10/15 16:56:46, abarth wrote: > > This change ...
6 years, 2 months ago (2014-10-15 20:51:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661513002/1
6 years, 2 months ago (2014-10-16 00:42:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 01:39:17 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 01:39:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5acd9fe37eae1ff654eb195960d30be0fa55f03f
Cr-Commit-Position: refs/heads/master@{#299810}

Powered by Google App Engine
This is Rietveld 408576698