Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1923)

Issue 661503003: Revert of Eliminate silently letting errors pass on pak loading. (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
CC:
chromium-reviews, newt (away)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Eliminate silently letting errors pass on pak loading. (patchset #18 id:340001 of https://codereview.chromium.org/537063002/) Reason for revert: Causing content_browsertests failures due to pak loading failure. Original issue's description: > Eliminate silently letting errors pass on pak loading. > > BUG=410411 > TEST=no visible change > > Committed: https://crrev.com/03c8c9d936594163d43222a3da0268b3dd9af656 > Cr-Commit-Position: refs/heads/master@{#299717} TBR=bengr@chromium.org,caitkp@chromium.org,tfarina@chromium.org,tony@chromium.org,avi@chromium.org NOTREECHECKS=true NOTRY=true BUG=410411 Committed: https://crrev.com/c52359d6e58c4ff403e9de8be5243f062eff969f Cr-Commit-Position: refs/heads/master@{#299794}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -77 lines) Patch
M components/components_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M components/test/run_all_unittests.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M content/public/test/test_content_client_initializer.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/test/test_content_client.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/base/resource/resource_bundle.cc View 3 chunks +10 lines, -6 lines 0 comments Download
M ui/base/resource/resource_bundle_ios.mm View 1 chunk +2 lines, -9 lines 0 comments Download
M ui/base/resource/resource_bundle_mac.mm View 1 chunk +2 lines, -8 lines 0 comments Download
M ui/base/resource/resource_bundle_unittest.cc View 3 chunks +9 lines, -1 line 0 comments Download
M ui/base/ui_base_paths.h View 1 chunk +1 line, -2 lines 0 comments Download
M ui/base/ui_base_paths.cc View 1 chunk +1 line, -5 lines 0 comments Download
M ui/base/ui_base_tests.gypi View 1 chunk +0 lines, -20 lines 0 comments Download
M ui/base/ui_base_tests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/ui_base_tests_bundle.gypi View 2 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dcheng
Created Revert of Eliminate silently letting errors pass on pak loading.
6 years, 2 months ago (2014-10-16 00:31:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661503003/1
6 years, 2 months ago (2014-10-16 00:33:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 00:36:58 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 00:37:31 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c52359d6e58c4ff403e9de8be5243f062eff969f
Cr-Commit-Position: refs/heads/master@{#299794}

Powered by Google App Engine
This is Rietveld 408576698