Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1510)

Unified Diff: content/browser/push_messaging_message_filter.h

Issue 661463002: Implement PushManager#hasPermission (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/push_messaging_message_filter.h
diff --git a/content/browser/push_messaging_message_filter.h b/content/browser/push_messaging_message_filter.h
index cab1b5ce82ffdcf60df458f8672c87e72b82f697..a2fe17b492980ac9bf0559a01876c91700729078 100644
--- a/content/browser/push_messaging_message_filter.h
+++ b/content/browser/push_messaging_message_filter.h
@@ -13,6 +13,7 @@
#include "content/public/common/push_messaging_status.h"
#include "url/gurl.h"
+class GURL;
Bernhard Bauer 2014/10/30 14:19:41 Nit: empty line afterwards
Miguel Garcia 2014/10/31 13:02:30 Done.
namespace content {
class PushMessagingService;
@@ -36,6 +37,10 @@ class PushMessagingMessageFilter : public BrowserMessageFilter {
bool user_gesture,
int service_worker_provider_id);
+ void OnPermissionStatusRequest(int render_frame_id,
+ int service_worker_provider_id,
+ int permission_callback_id);
+
void DoRegister(int render_frame_id,
int callbacks_id,
const std::string& sender_id,
@@ -49,6 +54,10 @@ class PushMessagingMessageFilter : public BrowserMessageFilter {
const std::string& push_registration_id,
PushRegistrationStatus status);
+ void DoPermissionStatusRequest(const GURL& requesting_origin,
Bernhard Bauer 2014/10/30 14:19:41 Nit: What's the order of methods here? I would eit
Miguel Garcia 2014/10/31 13:02:30 Done.
+ int render_frame_id,
+ int callback_id);
+
PushMessagingService* service();
int render_process_id_;

Powered by Google App Engine
This is Rietveld 408576698