Implement PushManager#hasPermission

content/browser/push_messaging_message_filter.h

Index: content/browser/push_messaging_message_filter.h
diff --git a/content/browser/push_messaging_message_filter.h b/content/browser/push_messaging_message_filter.h
index cab1b5ce82ffdcf60df458f8672c87e72b82f697..d20a7db73cd7cad3bc9b2dbdeeaf0cbb8a313154 100644
--- a/content/browser/push_messaging_message_filter.h
+++ b/content/browser/push_messaging_message_filter.h
@@ -13,6 +13,7 @@
 #include "content/public/common/push_messaging_status.h"
 #include "url/gurl.h"
 
+class GURL;
 namespace content {
 
 class PushMessagingService;
@@ -36,6 +37,10 @@ class PushMessagingMessageFilter : public BrowserMessageFilter {
                   bool user_gesture,
                   int service_worker_provider_id);
 
+  void OnPermissionStatus(int render_frame_id,

[mlamouri (slow - plz ping), 2014/10/29 20:13:33]

nit: this name sounds quite confusing to me. Could it be named
|OnPermissionStatusRequest|?

[Miguel Garcia, 2014/10/30 12:27:15]

Sure, it did not strike me as confusing but here it is.

+                          int service_worker_provider_id,
+                          int permission_callback_id);
+
   void DoRegister(int render_frame_id,
                   int callbacks_id,
                   const std::string& sender_id,
@@ -49,6 +54,10 @@ class PushMessagingMessageFilter : public BrowserMessageFilter {
                    const std::string& push_registration_id,
                    PushRegistrationStatus status);
 
+  void DoPermissionStatus(const GURL& requesting_origin,

[mlamouri (slow - plz ping), 2014/10/29 20:13:33]

nit: I think |DidGetPermissionStatus| would be a clearer name. The current name
is quite confusing.

[Miguel Garcia, 2014/10/30 12:27:15]

It is not really DidGet since by the time we call it we don't really know. I
think I am going with DoPermissionStatusRequest since that is the pattern
followed here (and usually) the IPC ones are Called OnX, then the callbacks are
called DoX 

+                          int render_frame_id,
+                          int callback_id);
+
   PushMessagingService* service();
 
   int render_process_id_;