Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3543)

Unified Diff: chrome/browser/content_settings/permission_context_base.h

Issue 661463002: Implement PushManager#hasPermission (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/permission_context_base.h
diff --git a/chrome/browser/content_settings/permission_context_base.h b/chrome/browser/content_settings/permission_context_base.h
index 48fcac8ce7bca3fa842952276d509c09560959ab..401ab1f428114887ed4abc2fb6a6276f81da23db 100644
--- a/chrome/browser/content_settings/permission_context_base.h
+++ b/chrome/browser/content_settings/permission_context_base.h
@@ -10,6 +10,7 @@
#include "base/memory/ref_counted.h"
#include "base/memory/weak_ptr.h"
#include "chrome/browser/ui/website_settings/permission_bubble_request.h"
+#include "components/content_settings/core/common/content_settings.h"
#include "components/content_settings/core/common/content_settings_types.h"
#include "components/keyed_service/core/keyed_service.h"
#include "url/gurl.h"
@@ -63,6 +64,10 @@ class PermissionContextBase : public KeyedService {
bool user_gesture,
const BrowserPermissionCallback& callback);
+ // Returns whether the permission has been granted, denied...
+ virtual ContentSetting PermissionStatus(const GURL& requesting_origin,
palmer 2014/10/29 20:45:25 Gloriously minor nit: choose 1 of -ing, -[oe]r. I'
Miguel Garcia 2014/10/30 12:27:15 Done. I took the chance and made the method const
+ const GURL& embedder_origin);
+
// Withdraw an existing permission request, no op if the permission request
// was already cancelled by some other means.
virtual void CancelPermissionRequest(content::WebContents* web_contents,

Powered by Google App Engine
This is Rietveld 408576698