Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Unified Diff: content/renderer/push_messaging_dispatcher.cc

Issue 661463002: Implement PushManager#hasPermission (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/push_messaging_dispatcher.cc
diff --git a/content/renderer/push_messaging_dispatcher.cc b/content/renderer/push_messaging_dispatcher.cc
index 1be95bd0b1119031c46329d90910bd0d39693eed..959d02ba5d456cd644f4ab77c00af17763679b40 100644
--- a/content/renderer/push_messaging_dispatcher.cc
+++ b/content/renderer/push_messaging_dispatcher.cc
@@ -11,6 +11,7 @@
#include "content/renderer/render_frame_impl.h"
#include "ipc/ipc_message.h"
#include "third_party/WebKit/public/platform/WebPushError.h"
+#include "third_party/WebKit/public/platform/WebPushPermissionCallback.h"
#include "third_party/WebKit/public/platform/WebPushRegistration.h"
#include "third_party/WebKit/public/platform/WebServiceWorkerProvider.h"
#include "third_party/WebKit/public/platform/WebString.h"
@@ -32,6 +33,9 @@ bool PushMessagingDispatcher::OnMessageReceived(const IPC::Message& message) {
IPC_BEGIN_MESSAGE_MAP(PushMessagingDispatcher, message)
IPC_MESSAGE_HANDLER(PushMessagingMsg_RegisterSuccess, OnRegisterSuccess)
IPC_MESSAGE_HANDLER(PushMessagingMsg_RegisterError, OnRegisterError)
+ IPC_MESSAGE_HANDLER(PushMessagingMsg_PermissionStatusResult,
+ OnPermissionStatus)
+
IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()
return handled;
@@ -68,6 +72,18 @@ void PushMessagingDispatcher::DoRegister(
service_worker_provider_id));
}
+void PushMessagingDispatcher::getPermissionStatus(
+ blink::WebPushPermissionCallback* callback,
+ blink::WebServiceWorkerProvider* service_worker_provider) {
+ int permission_callback_id = permission_check_callbacks_.Add(callback);
+ int service_worker_provider_id = static_cast<WebServiceWorkerProviderImpl*>(
+ service_worker_provider)->provider_id();
+ Send(new PushMessagingHostMsg_PermissionStatus(
+ routing_id(),
+ service_worker_provider_id,
+ permission_callback_id));
+}
+
void PushMessagingDispatcher::OnRegisterSuccess(
int32 callbacks_id,
const GURL& endpoint,
@@ -97,4 +113,13 @@ void PushMessagingDispatcher::OnRegisterError(int32 callbacks_id,
registration_callbacks_.Remove(callbacks_id);
}
+void PushMessagingDispatcher::OnPermissionStatus(
+ int32 callback_id,
+ blink::WebPushPermissionStatus type) {
Michael van Ouwerkerk 2014/10/24 12:36:08 tiny nit: I'd prefer status over type
Miguel Garcia 2014/10/29 18:32:03 Done.
+ blink::WebPushPermissionCallback* callback =
+ permission_check_callbacks_.Lookup(callback_id);
+ callback->onSuccess(type);
+ permission_check_callbacks_.Remove(callback_id);
+}
+
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698