Implement PushManager#hasPermission

chrome/browser/services/gcm/push_messaging_service_impl.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SERVICES_GCM_PUSH_MESSAGING_SERVICE_IMPL_H_
 #define CHROME_BROWSER_SERVICES_GCM_PUSH_MESSAGING_SERVICE_IMPL_H_
 
 #include "base/compiler_specific.h"
 #include "base/memory/weak_ptr.h"
 #include "components/gcm_driver/gcm_app_handler.h"
 #include "components/gcm_driver/gcm_client.h"
 #include "content/public/browser/push_messaging_service.h"
 #include "content/public/common/push_messaging_status.h"
+#include "third_party/WebKit/public/platform/WebPushPermissionCallback.h"
 
 class Profile;
 
+typedef blink::WebPushPermissionCallback::PushPermissionStatus
+    PushPermissionStatus;

[mlamouri (slow - plz ping), 2014/10/16 09:04:57]

Do we allow typedef's to be added in a header?

[Miguel Garcia, 2014/10/16 13:50:26]

I see this all the time
https://cs.corp.google.com/#search/&sq=package:%5Eclankium$&type=cs&q=typedef...

[mlamouri (slow - plz ping), 2014/10/17 09:30:56]

I see it being used inside classes or when a class define a complex type and
want consumers of the API it is exposing to have an easy access. It sounds
different in that case.

+
 namespace user_prefs {
 class PrefRegistrySyncable;
 }
 
 namespace gcm {
 
 class GCMProfileService;
 struct PushMessagingApplicationId;
 
 class PushMessagingServiceImpl : public content::PushMessagingService,
@@ skipping 23 matching lines @@
 
   // content::PushMessagingService implementation:
   virtual void Register(
       const GURL& origin,
       int64 service_worker_registration_id,
       const std::string& sender_id,
       int renderer_id,
       int render_frame_id,
       bool user_gesture,
       const content::PushMessagingService::RegisterCallback& callback) override;
+  virtual PushPermissionStatus PermissionStatus(
+      const GURL& requesting_origin, int renderer_id,
+      int render_frame_id) override;
 
  private:
   void DeliverMessageCallback(const PushMessagingApplicationId& application_id,
                               const GCMClient::IncomingMessage& message,
                               content::PushMessagingStatus status);
 
   void RegisterEnd(
       const content::PushMessagingService::RegisterCallback& callback,
       const std::string& registration_id,
       content::PushMessagingStatus status);
@@ skipping 14 matching lines @@
   Profile* profile_;  // It owns our owner.
 
   base::WeakPtrFactory<PushMessagingServiceImpl> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(PushMessagingServiceImpl);
 };
 
 }  // namespace gcm
 
 #endif  // CHROME_BROWSER_SERVICES_GCM_PUSH_MESSAGING_SERVICE_IMPL_H_