Prefix CommandLine usege with base namespace (Part 2: android_webview/)

Prefix CommandLine usege with base namespace (Part 2: android_webview/)

Prefix all CommandLine usage in the android_webview/ directory with
the base:: namespace.

BUG=422426
Committed: https://crrev.com/929d45a9ff9a74eb05453a10b84ba1a27392c1e6
Cr-Commit-Position: refs/heads/master@{#301593}

[elecro, 2014-10-15 15:28:40]

pgal.u-szeged@partner.samsung.com changed reviewers:
+ brettw@chromium.org, sgurun@chromium.org

[elecro, 2014-10-15 15:28:41]

PTAL

[brettw, 2014-10-15 17:55:16]

lgtm

https://codereview.chromium.org/661443003/diff/1/android_webview/browser/net/...
File android_webview/browser/net/aw_url_request_context_getter.cc (right):

https://codereview.chromium.org/661443003/diff/1/android_webview/browser/net/...
android_webview/browser/net/aw_url_request_context_getter.cc:74:
*CommandLine::ForCurrentProcess();
This second one needs a "base::" too (like you did above).

[sgurun-gerrit only, 2014-10-15 18:04:34]

On 2014/10/15 17:55:16, brettw wrote:
> lgtm
> 
>
https://codereview.chromium.org/661443003/diff/1/android_webview/browser/net/...
> File android_webview/browser/net/aw_url_request_context_getter.cc (right):
> 
>
https://codereview.chromium.org/661443003/diff/1/android_webview/browser/net/...
> android_webview/browser/net/aw_url_request_context_getter.cc:74:
> *CommandLine::ForCurrentProcess();
> This second one needs a "base::" too (like you did above).

I think under lib/main/aw_main_delegate.cc there is another case:

lib/main/aw_main_delegate.cc:  CommandLine* cl =
CommandLine::ForCurrentProcess();

[elecro, 2014-10-16 07:55:49]

On 2014/10/15 18:04:34, sgurun wrote:
> On 2014/10/15 17:55:16, brettw wrote:
> > lgtm
> > 
> >
>
https://codereview.chromium.org/661443003/diff/1/android_webview/browser/net/...
> > File android_webview/browser/net/aw_url_request_context_getter.cc (right):
> > 
> >
>
https://codereview.chromium.org/661443003/diff/1/android_webview/browser/net/...
> > android_webview/browser/net/aw_url_request_context_getter.cc:74:
> > *CommandLine::ForCurrentProcess();
> > This second one needs a "base::" too (like you did above).
> 
> I think under lib/main/aw_main_delegate.cc there is another case:
> 
> lib/main/aw_main_delegate.cc:  CommandLine* cl =
> CommandLine::ForCurrentProcess();

ah.. yeah, somehow I missed them.
I've updated the CL so now everything should have the correct base prefix.

[sgurun-gerrit only, 2014-10-16 15:41:58]

On 2014/10/16 07:55:49, elecro wrote:
> On 2014/10/15 18:04:34, sgurun wrote:
> > On 2014/10/15 17:55:16, brettw wrote:
> > > lgtm
> > > 
> > >
> >
>
https://codereview.chromium.org/661443003/diff/1/android_webview/browser/net/...
> > > File android_webview/browser/net/aw_url_request_context_getter.cc (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/661443003/diff/1/android_webview/browser/net/...
> > > android_webview/browser/net/aw_url_request_context_getter.cc:74:
> > > *CommandLine::ForCurrentProcess();
> > > This second one needs a "base::" too (like you did above).
> > 
> > I think under lib/main/aw_main_delegate.cc there is another case:
> > 
> > lib/main/aw_main_delegate.cc:  CommandLine* cl =
> > CommandLine::ForCurrentProcess();
> 
> ah.. yeah, somehow I missed them.
> I've updated the CL so now everything should have the correct base prefix.

lgtm

[elecro, 2014-10-20 16:23:08]

The CQ bit was checked by pgal.u-szeged@partner.samsung.com

[commit-bot: I haz the power, 2014-10-20 16:24:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/661443003/20001

[commit-bot: I haz the power, 2014-10-20 16:43:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-20 16:43:36]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[sgurun-gerrit only, 2014-10-21 20:34:14]

On 2014/10/20 16:43:36, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   android_dbg_tests_recipe on tryserver.chromium.linux
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

seems you have a bug here:
../../android_webview/browser/net/aw_url_request_context_getter.cc:55:13: error:
found ':' in nested-name-specifier, expected '::'
   const base:CommandLine& command_line =

[elecro, 2014-10-22 08:03:26]

On 2014/10/21 20:34:14, sgurun wrote:
> On 2014/10/20 16:43:36, I haz the power (commit-bot) wrote:
> > Try jobs failed on following builders:
> >   android_dbg_tests_recipe on tryserver.chromium.linux
> >
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
> 
> seems you have a bug here:
> ../../android_webview/browser/net/aw_url_request_context_getter.cc:55:13:
error:
> found ':' in nested-name-specifier, expected '::'
>    const base:CommandLine& command_line =

Yeah, that was fixed in the 3rd upload :)

[elecro, 2014-10-28 08:06:20]

The CQ bit was checked by pgal.u-szeged@partner.samsung.com

[commit-bot: I haz the power, 2014-10-28 08:07:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/661443003/40001

[commit-bot: I haz the power, 2014-10-28 08:09:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-28 08:09:44]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/74463)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  mac_chromium_rel on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[elecro, 2014-10-28 08:50:18]

The CQ bit was checked by pgal.u-szeged@partner.samsung.com

[commit-bot: I haz the power, 2014-10-28 08:51:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/661443003/60001

[commit-bot: I haz the power, 2014-10-28 11:50:52]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-10-28 11:51:38]

Patchset 4 (id:??) landed as
https://crrev.com/929d45a9ff9a74eb05453a10b84ba1a27392c1e6
Cr-Commit-Position: refs/heads/master@{#301593}