Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(917)

Issue 661443003: Prefix CommandLine usege with base namespace (Part 2: android_webview/) (Closed)

Created:
6 years, 2 months ago by elecro
Modified:
6 years, 1 month ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Prefix CommandLine usege with base namespace (Part 2: android_webview/) Prefix all CommandLine usage in the android_webview/ directory with the base:: namespace. BUG=422426 Committed: https://crrev.com/929d45a9ff9a74eb05453a10b84ba1a27392c1e6 Cr-Commit-Position: refs/heads/master@{#301593}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updated #

Patch Set 3 : android buildfix #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M android_webview/browser/browser_view_renderer.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/net/aw_url_request_context_getter.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M android_webview/common/aw_content_client.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M android_webview/common/aw_switches.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/lib/main/aw_main_delegate.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (6 generated)
elecro
PTAL
6 years, 2 months ago (2014-10-15 15:28:41 UTC) #2
brettw
lgtm https://codereview.chromium.org/661443003/diff/1/android_webview/browser/net/aw_url_request_context_getter.cc File android_webview/browser/net/aw_url_request_context_getter.cc (right): https://codereview.chromium.org/661443003/diff/1/android_webview/browser/net/aw_url_request_context_getter.cc#newcode74 android_webview/browser/net/aw_url_request_context_getter.cc:74: *CommandLine::ForCurrentProcess(); This second one needs a "base::" too ...
6 years, 2 months ago (2014-10-15 17:55:16 UTC) #3
sgurun-gerrit only
On 2014/10/15 17:55:16, brettw wrote: > lgtm > > https://codereview.chromium.org/661443003/diff/1/android_webview/browser/net/aw_url_request_context_getter.cc > File android_webview/browser/net/aw_url_request_context_getter.cc (right): > ...
6 years, 2 months ago (2014-10-15 18:04:34 UTC) #4
elecro
On 2014/10/15 18:04:34, sgurun wrote: > On 2014/10/15 17:55:16, brettw wrote: > > lgtm > ...
6 years, 2 months ago (2014-10-16 07:55:49 UTC) #5
sgurun-gerrit only
On 2014/10/16 07:55:49, elecro wrote: > On 2014/10/15 18:04:34, sgurun wrote: > > On 2014/10/15 ...
6 years, 2 months ago (2014-10-16 15:41:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661443003/20001
6 years, 2 months ago (2014-10-20 16:24:16 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/19831)
6 years, 2 months ago (2014-10-20 16:43:36 UTC) #10
sgurun-gerrit only
On 2014/10/20 16:43:36, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 2 months ago (2014-10-21 20:34:14 UTC) #11
elecro
On 2014/10/21 20:34:14, sgurun wrote: > On 2014/10/20 16:43:36, I haz the power (commit-bot) wrote: ...
6 years, 2 months ago (2014-10-22 08:03:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661443003/40001
6 years, 1 month ago (2014-10-28 08:07:02 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/74463) ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/builds/28006) mac_chromium_rel ...
6 years, 1 month ago (2014-10-28 08:09:44 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661443003/60001
6 years, 1 month ago (2014-10-28 08:51:03 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 1 month ago (2014-10-28 11:50:52 UTC) #19
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 11:51:38 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/929d45a9ff9a74eb05453a10b84ba1a27392c1e6
Cr-Commit-Position: refs/heads/master@{#301593}

Powered by Google App Engine
This is Rietveld 408576698