src/compiler/ast-graph-builder.cc - Issue 661433002: Implement the new semantics for 'super(...)'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/ast-graph-builder.cc

Issue 661433002: Implement the new semantics for 'super(...)' (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: CR feedback Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/ast-graph-builder.cc

diff --git a/src/compiler/ast-graph-builder.cc b/src/compiler/ast-graph-builder.cc

index 9c11c658a62763401f6f022078bd2b58751b8c62..ed4e689fe73a10f7bb0e61fc51e0ab505161de8a 100644

--- a/src/compiler/ast-graph-builder.cc

+++ b/src/compiler/ast-graph-builder.cc

@@ -1261,6 +1261,11 @@ void AstGraphBuilder::VisitCall(Call* expr) {

flags = CALL_AS_METHOD;

break;

}

+ case Call::SUPER_CALL: {

+ // todo(dslomov): implement super calls in turbofan.

+ UNREACHABLE();

Igor Sheludko 2014/10/17 08:40:34 UNIMPLEMENTED(); (UNREACHABLE is expanded to no-op

Dmitry Lomov (no reviews) 2014/10/17 09:15:47 Done.

+ break;

+ }

case Call::POSSIBLY_EVAL_CALL:

possibly_eval = true;

// Fall through.

« no previous file with comments | « src/ast.cc ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »