Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: chrome/browser/speech/tts_controller_unittest.cc

Issue 661423008: Standardize usage of virtual/override/final in chrome/browser/speech (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/speech/tts_controller_impl.h ('k') | chrome/browser/speech/tts_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/speech/tts_controller_unittest.cc
diff --git a/chrome/browser/speech/tts_controller_unittest.cc b/chrome/browser/speech/tts_controller_unittest.cc
index 7bd4155f668db31a1d297160dc4cc35df4bc60d6..9aa8450f71909e40c77459f22cabd3355baacc2c 100644
--- a/chrome/browser/speech/tts_controller_unittest.cc
+++ b/chrome/browser/speech/tts_controller_unittest.cc
@@ -16,31 +16,30 @@ class TtsApiControllerTest : public testing::Test {
class DummyTtsPlatformImpl : public TtsPlatformImpl {
public:
DummyTtsPlatformImpl() {}
- virtual ~DummyTtsPlatformImpl() {}
- virtual bool PlatformImplAvailable() override { return true; }
- virtual bool Speak(
- int utterance_id,
- const std::string& utterance,
- const std::string& lang,
- const VoiceData& voice,
- const UtteranceContinuousParameters& params) override {
+ ~DummyTtsPlatformImpl() override {}
+ bool PlatformImplAvailable() override { return true; }
+ bool Speak(int utterance_id,
+ const std::string& utterance,
+ const std::string& lang,
+ const VoiceData& voice,
+ const UtteranceContinuousParameters& params) override {
return true;
}
- virtual bool IsSpeaking() override { return false; }
- virtual bool StopSpeaking() override { return true; }
- virtual void Pause() override {}
- virtual void Resume() override {}
- virtual void GetVoices(std::vector<VoiceData>* out_voices) override {}
- virtual std::string error() override { return std::string(); }
- virtual void clear_error() override {}
- virtual void set_error(const std::string& error) override {}
+ bool IsSpeaking() override { return false; }
+ bool StopSpeaking() override { return true; }
+ void Pause() override {}
+ void Resume() override {}
+ void GetVoices(std::vector<VoiceData>* out_voices) override {}
+ std::string error() override { return std::string(); }
+ void clear_error() override {}
+ void set_error(const std::string& error) override {}
};
// Subclass of TtsController with a public ctor and dtor.
class TestableTtsController : public TtsControllerImpl {
public:
TestableTtsController() {}
- virtual ~TestableTtsController() {}
+ ~TestableTtsController() override {}
};
TEST_F(TtsApiControllerTest, TestTtsControllerShutdown) {
« no previous file with comments | « chrome/browser/speech/tts_controller_impl.h ('k') | chrome/browser/speech/tts_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698